Skip to content

Edit content field and remove type field from deliver-on-date.yml credits file#3430

Merged
Zak234 merged 1 commit intohackforla:gh-pagesfrom
ericvennemeyer:edit-content-remove-type-deliver-on-date-2809
Jul 27, 2022
Merged

Edit content field and remove type field from deliver-on-date.yml credits file#3430
Zak234 merged 1 commit intohackforla:gh-pagesfrom
ericvennemeyer:edit-content-remove-type-deliver-on-date-2809

Conversation

@ericvennemeyer
Copy link
Member

Fixes #2809

What changes did you make and why did you make them ?

  • Changed 'content: icon' to 'content-type: image' in line 4
  • Removed 'type: icon' from line 11

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Edited a credits yaml file. No visual changes to the website.

*Change 'content: icon' to 'content-type: image'
*Remove 'type: icon'
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ericvennemeyer-edit-content-remove-type-deliver-on-date-2809 gh-pages
git pull https://github.com/ericvennemeyer/website.git edit-content-remove-type-deliver-on-date-2809

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Jul 26, 2022
@tunglinn tunglinn self-requested a review July 27, 2022 01:14
@tunglinn
Copy link
Member

ETA: tonight
Availability: 1 hour

@Zak234 Zak234 self-requested a review July 27, 2022 01:48
Copy link
Member

@tunglinn tunglinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge branches look good. Changes completed as mentioned in issue. Doesn't break the site. Great job!

Copy link
Contributor

@Zak234 Zak234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Great work!

@Zak234 Zak234 self-requested a review July 27, 2022 20:04
Copy link
Contributor

@Zak234 Zak234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from deliver-on-date.yml credits file

3 participants