Skip to content

Alt Text Change for Palms Image#3441

Merged
blulady merged 3 commits intohackforla:gh-pagesfrom
d-perez-8:alt-text-change-3102
Aug 1, 2022
Merged

Alt Text Change for Palms Image#3441
blulady merged 3 commits intohackforla:gh-pagesfrom
d-perez-8:alt-text-change-3102

Conversation

@d-perez-8
Copy link
Member

Fixes #3102

What changes did you make and why did you make them ?

  • Changed line 51 from alt="palms neighborhood council logo" to alt="Palms Neighborhood Council"
  • Change were made to adhere to WCAG to make the alt text shorter

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changing the alt text. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b d-perez-8-alt-text-change-3102 gh-pages
git pull https://github.com/d-perez-8/website.git alt-text-change-3102

@github-actions github-actions bot added Feature: Accessibility Issues that would broaden website accessibility P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Jul 29, 2022
@Zak234 Zak234 self-requested a review July 29, 2022 02:44
@Zak234
Copy link
Contributor

Zak234 commented Jul 29, 2022

ETA: July 28
Availability: Anytime

@d-perez-8
Copy link
Member Author

Progress: Finished, but I am wondering why there are 2 commits when the edit content field and remove type field should have been merged already.
Blockers: None
Availability: Today and tomorrow until 2 PST
ETA: End of day

@arpitapandya arpitapandya self-requested a review July 29, 2022 03:35
@arpitapandya
Copy link
Member

Availability: 6 Hours
ETA: EOD 2022-07-30

@Zak234
Copy link
Contributor

Zak234 commented Jul 29, 2022

Looks like you might have commits from previous issues on your branch. I'll check in with the other merge team members and see if you need to revert the previous commit or if we can just merge it.

Copy link
Contributor

@Zak234 Zak234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work!

Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request is from d-perez-8:alt-text-change-3102 and it goes into hackforla:gh-pages. There is a linked issue, it is correct and addressed in the pull request by changing line 51 to alt="Palms Neighborhood Council". There are no changes in the browser and it looks the same when I throw the repo up locally.
Good Job!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Change alt text for Palms neighborhood council image in citizen engagement html file

5 participants