Skip to content

Edit content field and remove type field 2831#3515

Merged
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
plang-psm:edit-content-field-remove-type-field-2831
Sep 3, 2022
Merged

Edit content field and remove type field 2831#3515
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
plang-psm:edit-content-field-remove-type-field-2831

Conversation

@plang-psm
Copy link
Member

Fixes #2831

What changes did you make and why did you make them ?

  • Edit content: icon to content-type: image
  • Remove line 11: type:icon

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes made to website.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b plang-psm-edit-content-field-remove-type-field-2831 gh-pages
git pull https://github.com/plang-psm/website.git edit-content-field-remove-type-field-2831

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Sep 1, 2022
@plang-psm plang-psm requested a review from aalieu September 1, 2022 23:47
@giroz giroz self-requested a review September 2, 2022 00:35
@giroz
Copy link
Member

giroz commented Sep 2, 2022

ETA: 9-4-22
Availability: 3 hours

@lilyarj lilyarj self-requested a review September 2, 2022 00:48
@lilyarj
Copy link
Member

lilyarj commented Sep 2, 2022

ETA: 9/1
Availability: 2hrs

Copy link
Member

@lilyarj lilyarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, site doesn't break. In the future try not to delete spaces, even though it doesn't matter here I think, it might matter other times. Good job!

@arpitapandya
Copy link
Member

Availability: 6 Hours
ETA: EOD 2022-09-03

@arpitapandya arpitapandya self-requested a review September 3, 2022 15:19
Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are correct and doesn't break anything! Great job!! @plang-psm

@arpitapandya arpitapandya merged commit b1681e0 into hackforla:gh-pages Sep 3, 2022
Copy link
Member

@giroz giroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Especially on line 7. Good catch on the empty space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from external-mentor.yml credits file

4 participants