Skip to content

Edit content field and remove type field from giving.yml credits file issue 2828#3557

Merged
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
Unity7:edit-content-field-issue-2828
Sep 16, 2022
Merged

Edit content field and remove type field from giving.yml credits file issue 2828#3557
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
Unity7:edit-content-field-issue-2828

Conversation

@Unity7
Copy link
Member

@Unity7 Unity7 commented Sep 16, 2022

Fixes #2828

What changes did you make and why did you make them ?

Made changes to _data/internal/credits/giving.yml

  • Change line 4 for the content field from content: icon to content-type: image
  • Remove line 11 for the type field type: icon
  • changes were made because fields were redundant

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Unity7-edit-content-field-issue-2828 gh-pages
git pull https://github.com/Unity7/website.git edit-content-field-issue-2828

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Sep 16, 2022
@AzaniaBG AzaniaBG requested review from AzaniaBG and jqg123 September 16, 2022 02:21
@AzaniaBG AzaniaBG assigned AzaniaBG and Unity7 and unassigned AzaniaBG Sep 16, 2022
@AzaniaBG
Copy link
Member

Availability: afternoon of 09/16/2022
ETA: 09/16/2022 by 6 PM

@plang-psm
Copy link
Member

Review ETA: 11 PM 5/15/22
Availability: 2hrs Thursday

@plang-psm plang-psm self-requested a review September 16, 2022 04:55
Copy link
Member

@plang-psm plang-psm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation, no extra changes and runs fine. Solid work!

Copy link
Member

@AzaniaBG AzaniaBG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @Unity7 ~ it was easy to understand which changes you made.

@arpitapandya arpitapandya self-requested a review September 16, 2022 20:06
@arpitapandya
Copy link
Member

ETA: 2022-09-16
Availability: 30 minutes

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are correct and doesn't break anything!! Great job! @Unity7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from giving.yml credits file

4 participants