Change alt text for CFA logo image in citizen engagement html file Issue#3100#3561
Merged
arpitapandya merged 1 commit intohackforla:gh-pagesfrom Sep 21, 2022
Conversation
…erica logo to Code for America
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
Feature: Accessibility
neevliberman
approved these changes
Sep 18, 2022
Member
neevliberman
left a comment
neevliberman
left a comment
There was a problem hiding this comment.
This all looks good! You did everything the issue asked you to :)
In the future, you do not have to use images of changes in code on the website for your PR (i.e. if you need to inspect element to see the changes, it's probably not necessary). Really minute detail though! Great Job.
Member
|
ETA: 9/18/22 |
giroz
approved these changes
Sep 18, 2022
Member
giroz
left a comment
giroz
left a comment
There was a problem hiding this comment.
Great job! line 49 updated with correct text.
17 tasks
Member
|
Availability: 6hrs |
arpitapandya
suggested changes
Sep 19, 2022
Member
arpitapandya
left a comment
arpitapandya
left a comment
There was a problem hiding this comment.
- @Unity7 Great job on making changes!! The changes are absolutely correct and doesn't break anything.
- Please, do not attach any screenshot of code as per the upper line above screenshots you attached suggests.
- If the issue doesn't have any visible changes on website then it is perfectly fine not to attach screenshot. Just like in this issue, after changes there are no visible changes to the website.
- Please, Use docker setup to check website running guide on how to?, using Live-server through IDE isn't advisable for this project.
- Once you remove the screenshots, I shall be able to merge this PR.
12 tasks
Member
Author
|
@arpitapandya I have removed the screenshots |
arpitapandya
approved these changes
Sep 21, 2022
ExperimentsInHonesty
added
good first issue
This was referenced Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3100
What changes did you make and why did you make them ?
-Alt text was updated in order to be more accurate and web accessible
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
no changes to visuals