Skip to content

updated alt text for Mid-city neighborhood council image on line 55#3566

Merged
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
AzaniaBG:change-alt-text-in-html-3106
Sep 21, 2022
Merged

updated alt text for Mid-city neighborhood council image on line 55#3566
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
AzaniaBG:change-alt-text-in-html-3106

Conversation

@AzaniaBG
Copy link
Member

Fixes #3106

What changes did you make and why did you make them ?

  • changed line 55 alt text to "Mid-City Neighborhood Council"
  • changes made in citizen engagement html file

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to website; only changed alt text for image.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b AzaniaBG-change-alt-text-in-html-3106 gh-pages
git pull https://github.com/AzaniaBG/website.git change-alt-text-in-html-3106

@github-actions github-actions bot added Feature: Accessibility Issues that would broaden website accessibility P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Sep 19, 2022
@tunglinn tunglinn self-requested a review September 20, 2022 17:06
@tunglinn
Copy link
Member

ETA: today
Availability: 1hr

Copy link
Member

@tunglinn tunglinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge branches are good. Only changes mentioned in the issue are applied. Website does not break. Good work!

@mariareeves
Copy link
Member

ETA: 9/23/22
Availability: 4 hrs

@arpitapandya arpitapandya self-requested a review September 21, 2022 14:21
@arpitapandya
Copy link
Member

ETA: EOD 2022-09-21
Availability: 30 minutes

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are correct & doesn't break anything!! Great job! @AzaniaBG

  • Just one note for future PRs where you may be changing multiple lines of code, I would keep the title short for e.g updated citizen engagement image or modified neighborhood council image. Try not to include lines in the title.

You can always be more specific under ### What changes did you make and why did you make them?

@arpitapandya arpitapandya merged commit b1ed442 into hackforla:gh-pages Sep 21, 2022
@AzaniaBG AzaniaBG deleted the change-alt-text-in-html-3106 branch September 26, 2022 15:27
@AzaniaBG AzaniaBG restored the change-alt-text-in-html-3106 branch September 26, 2022 15:27
@AzaniaBG AzaniaBG deleted the change-alt-text-in-html-3106 branch September 26, 2022 15:28
@mariareeves mariareeves removed their request for review October 17, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Change alt text for Mid-city neighborhood council image in citizen engagement html file

5 participants