Skip to content

Edit and remove content and type fields from hammer.yml#3573

Merged
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
GRISONRF:edit-content-field-2834
Sep 21, 2022
Merged

Edit and remove content and type fields from hammer.yml#3573
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
GRISONRF:edit-content-field-2834

Conversation

@GRISONRF
Copy link
Member

@GRISONRF GRISONRF commented Sep 21, 2022

Fixes #2834

What changes did you make and why did you make them ?

  • Changed line 4 for the content field to 'content-type: image'
  • Removed 'type: icon'
  • Because it was redundant information and the changes made it easier to understand the code.

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b GRISONRF-edit-content-field-2834 gh-pages
git pull https://github.com/GRISONRF/website.git edit-content-field-2834

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Sep 21, 2022
@palomasoltys palomasoltys self-requested a review September 21, 2022 20:39
@jdingeman jdingeman self-requested a review September 21, 2022 22:01
@jdingeman
Copy link
Member

jdingeman commented Sep 21, 2022

ETA: 3:30pm
Availability: Today until EOD

jdingeman
jdingeman approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@jdingeman jdingeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good job.

@palomasoltys
Copy link
Member

palomasoltys commented Sep 21, 2022

ETA: 30min
Availability: 6-8pm EST

palomasoltys
palomasoltys approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@palomasoltys palomasoltys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Good job!

@arpitapandya arpitapandya merged commit 28f623b into hackforla:gh-pages Sep 21, 2022
@arpitapandya arpitapandya mentioned this pull request Sep 25, 2022
Open
17 tasks
@GRISONRF GRISONRF deleted the edit-content-field-2834 branch September 26, 2022 15:53
@kathrynsilvaconway kathrynsilvaconway mentioned this pull request Sep 28, 2022
Closed
12 tasks
This was referenced Aug 10, 2025
Closed
Closed
Closed
@t-will-gillis t-will-gillis mentioned this pull request Aug 22, 2025
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jdingeman jdingeman jdingeman approved these changes

@palomasoltys palomasoltys palomasoltys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

P: HfLA Website: Project Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from hammer.yml credits file

4 participants

@GRISONRF @jdingeman @palomasoltys @arpitapandya