Skip to content

Edit content field and remove type field from id.yml credits file#3576

Merged
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
michaelmagen:edit-credit-file-2842
Sep 24, 2022
Merged

Edit content field and remove type field from id.yml credits file#3576
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
michaelmagen:edit-credit-file-2842

Conversation

@michaelmagen
Copy link
Contributor

Fixes #2842

What changes did you make and why did you make them ?

  • Changed content to content-type in id.yml
  • Updated content-type to image in id.yml
  • Removed line 11 (type: icon) from id.yml

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Edited credits file data . No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b michaelmagen-edit-credit-file-2842 gh-pages
git pull https://github.com/michaelmagen/website.git edit-credit-file-2842

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Sep 23, 2022
@GRISONRF GRISONRF self-requested a review September 23, 2022 14:24
@GRISONRF
Copy link
Member

Review ETA: 8:30am 9/23/22
Availability: 9am-3pm Friday

Copy link
Member

@GRISONRF GRISONRF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Everything looks good.

@lilyarj lilyarj self-requested a review September 23, 2022 22:38
@lilyarj
Copy link
Member

lilyarj commented Sep 23, 2022

Eta: 9/23/22
Availability: 2hrs

Copy link
Member

@lilyarj lilyarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@arpitapandya arpitapandya self-requested a review September 24, 2022 00:33
@arpitapandya
Copy link
Member

ETA: EOD 2022-09-23
Availability: 30 minutes

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are correct and doesn't break anything. Great job!! @michaelmagen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from id.yml credits file

4 participants