Skip to content

Edit Content Field and Remove Type Field#3590

Merged
arpitapandya merged 5 commits intohackforla:gh-pagesfrom
jbialkin98:edit-content-field-2836
Sep 30, 2022
Merged

Edit Content Field and Remove Type Field#3590
arpitapandya merged 5 commits intohackforla:gh-pagesfrom
jbialkin98:edit-content-field-2836

Conversation

@jbialkin98
Copy link
Member

Fixes #2836

What changes did you make and why did you make them ?

  • Changed content field in line for to content-type
  • Removed line 11 (previously type: icon)

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jbialkin98-edit-content-field-2836 gh-pages
git pull https://github.com/jbialkin98/website.git edit-content-field-2836

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Sep 29, 2022
Copy link
Member

@kathrynsilvaconway kathrynsilvaconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbialkin98 Nice work submitting your first pull request. The word "image" in line 4 should have a lower case "i." Please ccorrect this and request a re-review after you push your changes, then I will approve them

@giroz giroz self-requested a review September 30, 2022 02:34
@plang-psm plang-psm self-requested a review September 30, 2022 02:34
@plang-psm
Copy link
Member

Availability: 6hrs
ETA: 10/3/22

@giroz
Copy link
Member

giroz commented Sep 30, 2022

ETA: 10-1-22
Availability: 3 hours

Copy link
Member

@plang-psm plang-psm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Besides changing the 'I' to 'i' in image, I was curious if you placed images in your description above. The 'Visual changes' before and after dropdown are not loading images just in case you did add anything there.

giroz
giroz previously requested changes Sep 30, 2022
Copy link
Member

@giroz giroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. You just have to adjust line 4 to have 'I' in 'Image' to look like 'i' in 'image'.

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are correct and doesn't break anything. Great job! @jbialkin98

@arpitapandya arpitapandya dismissed stale reviews from giroz and kathrynsilvaconway September 30, 2022 22:39

Discussed with Josh, and everything is correct

@arpitapandya arpitapandya merged commit bf8e900 into hackforla:gh-pages Sep 30, 2022
@arpitapandya
Copy link
Member

arpitapandya commented Sep 30, 2022

Nice work! Besides changing the 'I' to 'i' in image, I was curious if you placed images in your description above. The 'Visual changes' before and after dropdown are not loading images just in case you did add anything there.

@plang-psm Considered as there weren't any visual changes and reviewed the new changes. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from hands.yml credits file

5 participants