Edit Content Field and Remove Type Field#3590
Edit Content Field and Remove Type Field#3590arpitapandya merged 5 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
kathrynsilvaconway
left a comment
There was a problem hiding this comment.
@jbialkin98 Nice work submitting your first pull request. The word "image" in line 4 should have a lower case "i." Please ccorrect this and request a re-review after you push your changes, then I will approve them
|
Availability: 6hrs |
|
ETA: 10-1-22 |
plang-psm
left a comment
There was a problem hiding this comment.
Nice work! Besides changing the 'I' to 'i' in image, I was curious if you placed images in your description above. The 'Visual changes' before and after dropdown are not loading images just in case you did add anything there.
giroz
left a comment
There was a problem hiding this comment.
Good job. You just have to adjust line 4 to have 'I' in 'Image' to look like 'i' in 'image'.
arpitapandya
left a comment
There was a problem hiding this comment.
All the changes are correct and doesn't break anything. Great job! @jbialkin98
Discussed with Josh, and everything is correct
@plang-psm Considered as there weren't any visual changes and reviewed the new changes. Thanks |
Fixes #2836
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied