Edit content field and remove type field from job.yml#3615
Edit content field and remove type field from job.yml#3615blulady merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Hey Matt, |
|
ETA: 10/12/2022 |
There was a problem hiding this comment.
The changes were made in the correct branch and everything looks good.
Edit: I just noticed it some checks were not successful and I'm not sure why.
It got an error parsing the pull request body for all the linked issues, but I don't know if it's related to Matt's code, since everything looks right.
|
ETA: 10/13/22 |
Answer on why some checks fail: We have GitHub actions that check for linked issue when we create a pull request. I see that @MattPereira mistakenly typed |
|
Review ETA: 6 PM 10/15/22 |
gstemmann
left a comment
There was a problem hiding this comment.
Everything looks good to me. And the correct repositories were chosen.
blulady
left a comment
There was a problem hiding this comment.
This branch is coming from the correct branch and going into gh-pages. There is a linked issue, it is correct and addressed in the PR by changing line four to content-type: image and deleting line 11. The code looks clean and there is only one file changed.
Good job!!
giroz
left a comment
There was a problem hiding this comment.
Good job. line 4 added text, and line 11 deleted text
Fixes #2845
What changes did you make and why did you make them ?
key: valuepair in_data/internal/credits/job.yml_data/internal/credits/job.ymlThese changes were made to reduce redundancy in the code.
Screenshots of Proposed Changes Of The Website
Updating content field and type field of job.yml file. No visual changes to the website.