Skip to content

Credits-fix#3616

Merged
blulady merged 1 commit intohackforla:gh-pagesfrom
DmitriiTsy:credits
Oct 14, 2022
Merged

Credits-fix#3616
blulady merged 1 commit intohackforla:gh-pagesfrom
DmitriiTsy:credits

Conversation

@DmitriiTsy
Copy link
Member

@DmitriiTsy DmitriiTsy commented Oct 13, 2022

Fixes #2850

What changes did you make and why did you make them?

  • Opened file _data/internal/credits/office-worker.yml
  • Changed the name of the "content" line to "content-type" in the office-worket.yml file
  • Removed type line in the office-worket.yml file

Did that because content and type fields contained the same information before

@github-actions
Copy link

github-actions bot commented Oct 13, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b DmitriiTsy-credits gh-pages
git pull https://github.com/DmitriiTsy/website.git credits

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Oct 13, 2022
@jdingeman jdingeman self-requested a review October 13, 2022 03:27
@jdingeman
Copy link
Member

jdingeman commented Oct 13, 2022

Availability: 1 hr
ETA: EOD 10/12/2022

jdingeman
jdingeman approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@jdingeman jdingeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did not break credits page on site. Good job. 👍

@MattPereira MattPereira self-requested a review October 13, 2022 17:09
@MattPereira
Copy link
Contributor

MattPereira commented Oct 13, 2022 •
edited
Loading

Review ETA: 11 AM 10/13/22
Availability: 6 hours

MattPereira
MattPereira approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work Dmitrii! I love how you improved the code by removing redundancy. 👍

blulady
blulady approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is coming from the correct branch and going into gh-pages. There is a linked issue, it is correct and addressed in the PR by changing line four to content-type: image and deleting line 11. The code looks clean and there is only one file changed.
Good job!!

@blulady blulady merged commit e5dcada into hackforla:gh-pages Oct 14, 2022
@arpitapandya arpitapandya mentioned this pull request Oct 16, 2022
Open
17 tasks
This was referenced Aug 10, 2025
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@blulady blulady blulady approved these changes

@MattPereira MattPereira MattPereira approved these changes

@jdingeman jdingeman jdingeman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

P: HfLA Website: Project Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from office-worker.yml credits file

4 participants

@DmitriiTsy @jdingeman @MattPereira @blulady