Skip to content

Updated Content Field and Removed Type Field in meetup.yml#3620

Merged
blulady merged 1 commit intohackforla:gh-pagesfrom
esantiano:edit-content-remove-fields-meetup-2848
Oct 16, 2022
Merged

Updated Content Field and Removed Type Field in meetup.yml#3620
blulady merged 1 commit intohackforla:gh-pagesfrom
esantiano:edit-content-remove-fields-meetup-2848

Conversation

@esantiano
Copy link
Member

@esantiano esantiano commented Oct 14, 2022

Fixes #2848

What changes did you make and why did you make them ?

  • updated line 4 "content: icon" to "content-type: image" changed for clarity.
  • deleted line 11 " type: icon" done to cut down redundant fields.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b esantiano-edit-content-remove-fields-meetup-2848 gh-pages
git pull https://github.com/esantiano/website.git edit-content-remove-fields-meetup-2848

@github-actions github-actions bot added 2 weeks inactive good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Oct 14, 2022
@d-perez-8 d-perez-8 self-requested a review October 14, 2022 22:29
@d-perez-8
Copy link
Member

ETA: 1 hour
Availability: All day 10/14/2022

Copy link
Member

@d-perez-8 d-perez-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The website does not break, and you have completed the issue correctly.

For the future, you can check off the checklist in the issue you were working on so we know your progress. Also, you do not need the image section of the pull request if there are no visual changes to the website.

Thank you for your time and work!

@MattPereira MattPereira self-requested a review October 15, 2022 17:06
@MattPereira
Copy link
Contributor

Review ETA: 10:30 AM 10/15/22
Availability: 10 AM - 4 PM Saturday

Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Esantiano! I love how you linked the issue and removed redundant code!

@jdingeman jdingeman requested review from jdingeman and removed request for jdingeman October 15, 2022 20:40
Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is coming from the correct branch and going into gh-pages. There is a linked issue, it is correct and addressed in the PR by changing line four to content-type: image and deleting line 11. The code looks clean, only one commit and only one file changed.
Good job!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from meetup.yml credits file

4 participants