Skip to content

3202 removed alt-hero field from home-unite-us file#3628

Merged
jdingeman merged 2 commits intohackforla:gh-pagesfrom
Suman2795:3202-HomeUniteUsfile-remove-alt_hero
Oct 17, 2022
Merged

3202 removed alt-hero field from home-unite-us file#3628
jdingeman merged 2 commits intohackforla:gh-pagesfrom
Suman2795:3202-HomeUniteUsfile-remove-alt_hero

Conversation

@Suman2795
Copy link
Member

Fixes #3202

What changes did you make and why did you make them ?

-Removed unused alt-hero field from Home-unite-us file

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Suman2795-3202-HomeUniteUsfile-remove-alt_hero gh-pages
git pull https://github.com/Suman2795/website.git 3202-HomeUniteUsfile-remove-alt_hero

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Oct 16, 2022
@jyaymie jyaymie self-requested a review October 16, 2022 17:18
@jyaymie
Copy link
Member

jyaymie commented Oct 16, 2022

Review ETA: 10/16/22 EOD
Availability: 4 hours

@giroz giroz self-requested a review October 16, 2022 17:21
@giroz
Copy link
Member

giroz commented Oct 16, 2022

ETA: 10-17-22
Availability: 2 hours

Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work removing the unused text! That said, based on my interpretation of the issue, I think line 8 needs to be removed completely?

@Suman2795
Copy link
Member Author

@jyaymie Thanks for requesting changes! I have deleted the line completely now.

@jdingeman jdingeman merged commit 5910877 into hackforla:gh-pages Oct 17, 2022
Copy link
Member

@giroz giroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I know a little late but I got through it. Nice delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from home-unite-us.md project file

5 participants