Skip to content

Remove unused alt-hero from file#3631

Merged
jdingeman merged 1 commit intohackforla:gh-pagesfrom
jbialkin98:remove-field-jobs-3203
Oct 17, 2022
Merged

Remove unused alt-hero from file#3631
jdingeman merged 1 commit intohackforla:gh-pagesfrom
jbialkin98:remove-field-jobs-3203

Conversation

@jbialkin98
Copy link
Member

Fixes #3203

What changes did you make and why did you make them ?

  • Removed line 8 from code, which was the alt-hero field

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jbialkin98-remove-field-jobs-3203 gh-pages
git pull https://github.com/jbialkin98/website.git remove-field-jobs-3203

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Oct 17, 2022
@AzaniaBG AzaniaBG self-requested a review October 17, 2022 20:16
@AzaniaBG
Copy link
Member

PR review availability: 10/17/2022 1:15 pm - 2:15 pm
review ETA: 10/17/2022

Copy link
Member

@AzaniaBG AzaniaBG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work making changes that address this issue @jbialkin98. I'm not sure which images you uploaded because they are not showing up. If those are just screenshots of the code, no need to include them in your PR :)

@jdingeman jdingeman merged commit 0475c1d into hackforla:gh-pages Oct 17, 2022
@richardmundyiii richardmundyiii self-requested a review March 18, 2023 23:22
@richardmundyiii
Copy link
Member

Availability: 3/18 4pm - 6pm
ETA: EOD 3/18/23

Copy link
Member

@richardmundyiii richardmundyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbialkin98 Great job on your 2nd PR! The requested changes were made in the correct document, the branch is setup correctly, and the issue is properly linked.

As mentioned before, if your PR does not include any visual changes there is no need to send a screenshot of the code. However, leave a note as to why you didn't leave a screenshot as to follow the Contributing instructions guidelines. It should include something like this:

### Screenshots of Proposed Changes Of The Website  (if any, please do not screenshot code changes)

Only removed alt-text code. No visual changes to the website.

Overall, great work, and thank you for your time and effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from jobs-for-hope.md project file

5 participants