Skip to content

Edited content field and removed type field from mentor.yaml file#3645

Merged
jdingeman merged 1 commit intohackforla:gh-pagesfrom
patrickohh:edit-content-field-remove-type-field-2849
Oct 21, 2022
Merged

Edited content field and removed type field from mentor.yaml file#3645
jdingeman merged 1 commit intohackforla:gh-pagesfrom
patrickohh:edit-content-field-remove-type-field-2849

Conversation

@patrickohh
Copy link
Member

Fixes #2849

What changes did you make and why did you make them ?

-Changed content field to content type: image
-Removed type field

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes made to website.

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Oct 20, 2022
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b patrickohh-edit-content-field-remove-type-field-2849 gh-pages
git pull https://github.com/patrickohh/website.git edit-content-field-remove-type-field-2849

@MattPereira MattPereira self-requested a review October 20, 2022 22:51
@MattPereira
Copy link
Contributor

Review ETA: 4:20 PM 10/20/22
Availability: 4 - 5 PM Thursday

Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work Patrick! 👍

I love how you removed the redundant code from _data/internal/credits/mentor.yml

@michaelmagen michaelmagen self-requested a review October 20, 2022 23:46
@michaelmagen
Copy link
Contributor

Review ETA: 5:30 PM 10/20/22
Availability: 5-7 PM Thursday

Copy link
Contributor

@michaelmagen michaelmagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from mentor.yml credits file

4 participants