Fixes #2852: Edit people.yml content field to content-type and remove type field#3650
Merged
jdingeman merged 1 commit intohackforla:gh-pagesfrom Oct 24, 2022
Merged
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
Contributor
|
Review ETA: 12 PM 10/24/22 |
MattPereira
approved these changes
Oct 24, 2022
Contributor
MattPereira
left a comment
MattPereira
left a comment
There was a problem hiding this comment.
Good work @str-xjua24 ! 👍
I love how you removed the redundant code from _data/internal/credits/people.yml to make it easier to understand!
Member
|
review ETA: 5 pm 10/24 |
Member
There was a problem hiding this comment.
Hi @str-xjua24 -
Congrats on your first pull request! This looks correct, great job
t-will-gillis
approved these changes
Oct 24, 2022
Member
t-will-gillis
left a comment
t-will-gillis
left a comment
There was a problem hiding this comment.
Hi @str-xjua24 -
Congrats on your first pull request! This looks correct, great job
12 tasks
This was referenced Aug 11, 2025
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2852
What changes did you make and why did you make them?
-Edit content field to content-type and changed value from icon to image
-Removed redundant type field
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Minor changes to people.yml for better code readability and redundant code removed. List is self-explanatory.