Skip to content

Updated fields in people2.yml credits file #2853#3658

Merged
arpitapandya merged 2 commits intohackforla:gh-pagesfrom
ldaws003:gh-pages
Oct 26, 2022
Merged

Updated fields in people2.yml credits file #2853#3658
arpitapandya merged 2 commits intohackforla:gh-pagesfrom
ldaws003:gh-pages

Conversation

@ldaws003
Copy link
Member

@ldaws003 ldaws003 commented Oct 25, 2022 •
edited
Loading

…th content-type: image

Fixes #2853

What changes did you make and why did you make them ?

  • replaced the line containing "content: icon" with "content-type: image"
  • removed line containing "type: icon"
  • these were done to remove redundancy

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changing fields in yml file. No visual changes to website.

@github-actions
Copy link

github-actions bot commented Oct 25, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ldaws003-gh-pages gh-pages
git pull https://github.com/ldaws003/website.git gh-pages

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Oct 25, 2022
@Unity7 Unity7 self-requested a review October 25, 2022 13:37
@Unity7
Copy link
Member

Unity7 commented Oct 25, 2022

Availability: 2 Hours
ETA: EOD 10/25/22

@jyaymie jyaymie self-requested a review October 25, 2022 21:30
@jyaymie
Copy link
Member

jyaymie commented Oct 25, 2022

Review ETA: 10/25/22 3:30pm
Availability: 1 hour

jyaymie
jyaymie approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR was done with the correct branch and all the requested changes from the linked issue were made. Fantastic job, @ldaws003!

@arpitapandya arpitapandya merged commit 61ef011 into hackforla:gh-pages Oct 26, 2022
@kathrynsilvaconway kathrynsilvaconway mentioned this pull request Oct 26, 2022
Closed
12 tasks
arpitapandya added a commit that referenced this pull request Oct 31, 2022
@arpitapandya
Revert "updated people2.yml, removed type: icon and replaced content:…
60f1185 
… icon with content-type: image (#3658)"

This reverts commit 61ef011.
@arpitapandya arpitapandya mentioned this pull request Oct 31, 2022
Merged
jdingeman pushed a commit that referenced this pull request Oct 31, 2022
@arpitapandya
Revert "updated people2.yml, removed type: icon and replaced content:…
d62be5b 
… icon with content-type: image (#3658)" (#3680)

This reverts commit 61ef011.
This was referenced Aug 10, 2025
Closed
Closed
Closed
@t-will-gillis t-will-gillis mentioned this pull request Aug 22, 2025
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Unity7 Unity7 Awaiting requested review from Unity7

1 more reviewer

@jyaymie jyaymie jyaymie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

P: HfLA Website: Project Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from people2.yml credits file

4 participants

@ldaws003 @Unity7 @jyaymie @arpitapandya