Skip to content

Updated content and type fields in people2.yml credits file #2853#3686

Merged
jdingeman merged 2 commits intohackforla:gh-pagesfrom
ldaws003:edit-field-people2_yml-2853
Nov 2, 2022
Merged

Updated content and type fields in people2.yml credits file #2853#3686
jdingeman merged 2 commits intohackforla:gh-pagesfrom
ldaws003:edit-field-people2_yml-2853

Conversation

@ldaws003
Copy link
Member

@ldaws003 ldaws003 commented Nov 1, 2022

Fixes #2853

What changes did you make and why did you make them ?

  • replaced the line containing "content: icon" with "content-type: image"
  • removed line containing "type: icon"
  • these were done to remove redundancy
  • made sure that this was done in a topic branch

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changing fields in yml file. No visual changes to website.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ldaws003-edit-field-people2_yml-2853 gh-pages
git pull https://github.com/ldaws003/website.git edit-field-people2_yml-2853

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Nov 1, 2022
@roslynwythe roslynwythe self-requested a review November 1, 2022 07:21
@roslynwythe
Copy link
Member

Reviewing..
ETA 2 am 11/1/2022
Availability: 1 am - 1 pm 11/1/2022

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Leon. Your changes were appropriate and your description is excellent! Thank you.

@jyaymie jyaymie self-requested a review November 2, 2022 02:11
@jyaymie
Copy link
Member

jyaymie commented Nov 2, 2022

Review ETA: 11/1/22 7:30pm
Availability: 3 hours

Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @ldaws003! You linked the issue and took care of all its action items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from people2.yml credits file

4 participants