edit content field, removed type field from yml credits#3687
edit content field, removed type field from yml credits#3687luiderek wants to merge 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 11/1/22 7:30pm |
jyaymie
left a comment
There was a problem hiding this comment.
Fantastic job, @luiderek! You took care of all the action items without making any visible changes to the website. One thing I've been doing when coming up with a branch name is choosing the number of the dependency (in this case, #2856) rather than the issue it's being tracked by (#2775) so it's clear to reviewers that I am only managing the dependency.
|
Yeah, I realized I put in the wrong issue # for my commit / branchname after making the pull request (i had a lot of different tabs open), but wasn't sure if undoing the pull request was the right move in this situation. Just gotta be more careful. |
Gotcha. I would've also committed to this PR and maybe included a small note for my oopsie. I'd be curious to know what the leads would do! |
|
Ah, it looks like renaming the branch kills it. Should I restore it or just open a new pull request? |
Whatever is easy for you, I think its a small issue if you can create a new branch |
Fixes #2856
What changes did you make and why did you make them
for the file:
_data/internal/credits/process.ymlcontentfield withcontent-typetypefield