Skip to content

edit content field, removed type field from yml credits#3687

Closed
luiderek wants to merge 1 commit intohackforla:gh-pagesfrom
luiderek:update-process-yml-2775
Closed

edit content field, removed type field from yml credits#3687
luiderek wants to merge 1 commit intohackforla:gh-pagesfrom
luiderek:update-process-yml-2775

Conversation

@luiderek
Copy link
Member

@luiderek luiderek commented Nov 1, 2022

Fixes #2856

What changes did you make and why did you make them

for the file: _data/internal/credits/process.yml

  • replaced the content field with content-type
  • removed the type field

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b luiderek-update-process-yml-2775 gh-pages
git pull https://github.com/luiderek/hfla-website.git update-process-yml-2775

@github-actions github-actions bot added Collaborative Work Dependency An issue is blocking the completion or starting of another issue epic P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours Complexity: Small Take this type of issues after the successful merge of your second good first issue status: Updated No blockers and update is ready for review good first issue Good for newcomers role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less and removed Collaborative Work status: Updated No blockers and update is ready for review Dependency An issue is blocking the completion or starting of another issue Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 2pt Can be done in 7-12 hours epic labels Nov 1, 2022
@jyaymie jyaymie self-requested a review November 2, 2022 01:50
@jyaymie
Copy link
Member

jyaymie commented Nov 2, 2022

Review ETA: 11/1/22 7:30pm
Availability: 2 hours

Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job, @luiderek! You took care of all the action items without making any visible changes to the website. One thing I've been doing when coming up with a branch name is choosing the number of the dependency (in this case, #2856) rather than the issue it's being tracked by (#2775) so it's clear to reviewers that I am only managing the dependency.

@luiderek
Copy link
Member Author

luiderek commented Nov 2, 2022

Yeah, I realized I put in the wrong issue # for my commit / branchname after making the pull request (i had a lot of different tabs open), but wasn't sure if undoing the pull request was the right move in this situation. Just gotta be more careful.

@jyaymie
Copy link
Member

jyaymie commented Nov 2, 2022

Yeah, I realized I put in the wrong issue # for my commit / branchname after making the pull request (i had a lot of different tabs open), but wasn't sure if undoing the pull request was the right move in this situation. Just gotta be more careful.

Gotcha. I would've also committed to this PR and maybe included a small note for my oopsie. I'd be curious to know what the leads would do!

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luiderek to resolve that, can you check here and see if you can rename it. I see the automation got confused between labels.
I can merge PR, not a big issue but I don't want the number which is irrelevant as it's being tracked and may create other problems.

@luiderek luiderek closed this Nov 2, 2022
@luiderek luiderek deleted the update-process-yml-2775 branch November 2, 2022 04:47
@luiderek
Copy link
Member Author

luiderek commented Nov 2, 2022

Ah, it looks like renaming the branch kills it. Should I restore it or just open a new pull request?

@arpitapandya
Copy link
Member

Ah, it looks like renaming the branch kills it. Should I restore it or just open a new pull request?

Whatever is easy for you, I think its a small issue if you can create a new branch

@luiderek
Copy link
Member Author

luiderek commented Nov 2, 2022

#3689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from process.yml credits file

3 participants