Skip to content

Updated content field and removed type field in credits/review.yml#3718

Merged
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
angelenelm:update-review-yml-in-credits-2860
Nov 17, 2022
Merged

Updated content field and removed type field in credits/review.yml#3718
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
angelenelm:update-review-yml-in-credits-2860

Conversation

@angelenelm
Copy link
Member

Fixes #2860

What changes did you make and why did you make them?

Per the action items:

  • Changed line 4 for the content field from
content: icon

to

content-type: image
  • Removed line 11 for the type field
type: icon

Screenshots of proposed changes of the website (if any, please do not screenshot code changes)

  • No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b angelenelm-update-review-yml-in-credits-2860 gh-pages
git pull https://github.com/angelenelm/website.git update-review-yml-in-credits-2860

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Nov 15, 2022
@d-perez-8 d-perez-8 self-requested a review November 15, 2022 01:30
@d-perez-8
Copy link
Member

ETA: 1 hour
Availability: 3:30 pm to 6 pm weekdays

Copy link
Member

@d-perez-8 d-perez-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking on this issue! You have completed the issue correctly and the website does not break.

Great job!

@Suman2795 Suman2795 self-requested a review November 15, 2022 05:27
@Suman2795
Copy link
Member

Review ETA: 1 hour
Avaialbility: 15/11/2022

@jyaymie jyaymie self-requested a review November 15, 2022 06:10
@jyaymie
Copy link
Member

jyaymie commented Nov 15, 2022

Review ETA: 11/14/22 11pm
Availability: 11/14/22 1 hour

Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You successfully made the changes requested in the linked issue, and your PR was done on the correct branch. Awesome work, @angelenelm!

Copy link
Member

@Suman2795 Suman2795 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are done correctly and to right branch. Good job!

Copy link
Member

@Skydodle Skydodle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your update to the content field was done correctly and pull request documented well. Great job @angelenelm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from review.yml credits file

6 participants