Skip to content

Removed alt-hero field from _projects/spare.md file#3729

Merged
MattPereira merged 1 commit intohackforla:gh-pagesfrom
angelenelm:remove-alt-hero-field-from-projects-spare-md-3211
Nov 18, 2022
Merged

Removed alt-hero field from _projects/spare.md file#3729
MattPereira merged 1 commit intohackforla:gh-pagesfrom
angelenelm:remove-alt-hero-field-from-projects-spare-md-3211

Conversation

@angelenelm
Copy link
Member

@angelenelm angelenelm commented Nov 17, 2022

Fixes #3211

What changes did you make and why did you make them?

  • Per the action items, for the file _projects/spare.md, removed line 8 for the alt-hero
alt-hero: ''

Screenshots of proposed changes of the website (if any; please do not screenshot code changes)

  • No visual changes to the website.

@github-actions
Copy link

github-actions bot commented Nov 17, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b angelenelm-remove-alt-hero-field-from-projects-spare-md-3211 gh-pages
git pull https://github.com/angelenelm/website.git remove-alt-hero-field-from-projects-spare-md-3211

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Nov 17, 2022
@t-will-gillis t-will-gillis self-requested a review November 18, 2022 00:53
@t-will-gillis
Copy link
Member

t-will-gillis commented Nov 18, 2022

Availability: Friday, 11/18, 12-5
Review ETA: Friday 5pm

@giroz giroz self-requested a review November 18, 2022 01:11
@giroz
Copy link
Member

giroz commented Nov 18, 2022

ETA: 11/18/22
Availability: 2 hours

@Suman2795 Suman2795 self-requested a review November 18, 2022 02:33
@Suman2795
Copy link
Member

Suman2795 commented Nov 18, 2022

ETA:18/11/2022
Availability: 2 hours

Suman2795
Suman2795 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@Suman2795 Suman2795 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Changes are made into the correct branch and are done as asked in the issue.

t-will-gillis
t-will-gillis approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @angelenelm - good job! You followed the linked issue, deleted the correct line, left the code cleaner!

MattPereira
MattPereira approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done and great job explaining your changes @angelenelm ! 👍

@MattPereira MattPereira merged commit 95c2c2c into hackforla:gh-pages Nov 18, 2022
@angelenelm angelenelm deleted the remove-alt-hero-field-from-projects-spare-md-3211 branch November 18, 2022 22:28
giroz
giroz reviewed Nov 19, 2022
View reviewed changes
Copy link
Member

@giroz giroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! Well done deleting text.

This was referenced Aug 10, 2025
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-will-gillis t-will-gillis t-will-gillis approved these changes

+3 more reviewers

@giroz giroz giroz left review comments

@MattPereira MattPereira MattPereira approved these changes

@Suman2795 Suman2795 Suman2795 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

P: HfLA Website: Project Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from spare.md project file

6 participants

@angelenelm @t-will-gillis @giroz @Suman2795 @MattPereira @ExperimentsInHonesty