Skip to content

edited content field from yml credit files#3799

Merged
jdingeman merged 1 commit intohackforla:gh-pagesfrom
rdpfeifle:edit-content-field-2865
Jan 10, 2023
Merged

edited content field from yml credit files#3799
jdingeman merged 1 commit intohackforla:gh-pagesfrom
rdpfeifle:edit-content-field-2865

Conversation

@rdpfeifle
Copy link
Member

Fixes #2865

What changes did you make and why did you make them?

  • Edited file _data/internal/credits/team.yml by removing the "type" field and modifying "content" to "content-type: image".

@rdpfeifle rdpfeifle requested a review from aalieu January 9, 2023 17:37
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b rdpfeifle-edit-content-field-2865 gh-pages
git pull https://github.com/rdpfeifle/website.git edit-content-field-2865

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Jan 9, 2023
@jyaymie jyaymie self-requested a review January 9, 2023 22:27
@jyaymie
Copy link
Member

jyaymie commented Jan 9, 2023

Review ETA: 1/9/23 3pm
Availability: 1/9/23 til 5pm

Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You correctly linked the issue, made the appropriate changes, and used the right branches in the PR. Fantastic work, @rdpfeifle!

@jdingeman jdingeman merged commit 4931ad0 into hackforla:gh-pages Jan 10, 2023
@rdpfeifle
Copy link
Member Author

Availability for this week: flexible, probably M-F from 9-6 MT
My estimated ETA for completing this issue: ~15 minutes

@rdpfeifle
Copy link
Member Author

Provide Update

  1. Progress: done
  2. Blockers: none so far
  3. Availability: flexible, probably M-F from 9-6 MT
  4. ETA: same day, took about 15 minutes to complete my first issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from team.yml credits file

3 participants