Skip to content

Edit content field and remove type field from teamwork.yml credits file #2861#3807

Merged
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
kotynskm:edit-content-field-type-field-teamwork-2861
Jan 12, 2023
Merged

Edit content field and remove type field from teamwork.yml credits file #2861#3807
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
kotynskm:edit-content-field-type-field-teamwork-2861

Conversation

@kotynskm
Copy link
Member

@kotynskm kotynskm commented Jan 10, 2023

Fixes #2861

What changes did you make and why did you make them ?

  • Changed line 4 from content to content-type: image
  • Removed type field on line 11

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changed contents in file. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kotynskm-edit-content-field-type-field-teamwork-2861 gh-pages
git pull https://github.com/kotynskm/website.git edit-content-field-type-field-teamwork-2861

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Jan 10, 2023
@jyaymie jyaymie self-requested a review January 11, 2023 02:15
@jyaymie
Copy link
Member

jyaymie commented Jan 11, 2023

Review ETA: 1/10/23 6:30pm
Availability: 1/10/23 til 9pm

Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You correctly linked the issue, made appropriate changes, and used the right branches in your PR. Excellent job, @kotynskm!

@arpitapandya arpitapandya merged commit 2dd6b1d into hackforla:gh-pages Jan 12, 2023
@kotynskm kotynskm deleted the edit-content-field-type-field-teamwork-2861 branch January 12, 2023 21:39
@richardmundyiii richardmundyiii self-requested a review March 18, 2023 23:42
Copy link
Member

@richardmundyiii richardmundyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kotynskm Great job on your first PR! The requested changes were made in the correct document, the branch is set up correctly, and the issue is properly linked.

Thank you for your time and keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from teamwork.yml credits file

4 participants