Skip to content

Change alt text 3401#3808

Merged
arpitapandya merged 3 commits intohackforla:gh-pagesfrom
maryjng:change-alt-text-3401
Jan 13, 2023
Merged

Change alt text 3401#3808
arpitapandya merged 3 commits intohackforla:gh-pagesfrom
maryjng:change-alt-text-3401

Conversation

@maryjng
Copy link
Member

@maryjng maryjng commented Jan 11, 2023

Fixes #3401

What changes did you make and why did you make them ?

  • Per issue instructions, updated alt text on file Line 53 from "Climate Action goal logo" to "13 Climate Action"

Screenshots of Proposed Changes Of The Website

  • No visual changes were made to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b maryjng-change-alt-text-3401 gh-pages
git pull https://github.com/maryjng/hackforla.git change-alt-text-3401

@github-actions github-actions bot added Feature: Accessibility Issues that would broaden website accessibility P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Jan 11, 2023
@jyaymie jyaymie self-requested a review January 11, 2023 02:19
@jyaymie
Copy link
Member

jyaymie commented Jan 11, 2023

Review ETA: 1/10/23 6:30pm
Availability: 1/10/23 til 9pm

Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @maryjng! You made the changes discussed in the linked issue and used the correct branches in your PR. However, additional changes in _data/internal/credits/website.yml appear to be beyond the scope of the issue. Were these changes part of your good first issue? Maybe your local repo was not up-to-date with the main site before you worked on this second issue? In any case, I would restore the code as it was in that file and make another commit. Let me know what you think!

@jyaymie
Copy link
Member

jyaymie commented Jan 11, 2023

Oh! I see that your good first issue has not yet been merged. We typically wait until our PR is merged before we move on to another issue, but I think keeping this PR will be ok once those changes are removed.

@maryjng maryjng requested a review from jyaymie January 11, 2023 15:25
Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've fulfilled the issue's requirements. Approved!

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryjng Code changes are correct, but before I merge could you assign yourself to add issue, move it from prioritized-backlog to in progress- actively working column and add your ETA and Availability to the issue. #3401.

@maryjng maryjng self-assigned this Jan 13, 2023
@maryjng maryjng requested a review from arpitapandya January 13, 2023 05:12
@github-actions github-actions bot added the status: Updated No blockers and update is ready for review label Jan 13, 2023
Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are correct! Great job!! @maryjng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less status: Updated No blockers and update is ready for review

Projects

Development

Successfully merging this pull request may close these issues.

Update alt text for Climate Action goal logo on the About Us page to adhere to WCAG

4 participants