Change alt text 3401#3808
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 1/10/23 6:30pm |
There was a problem hiding this comment.
Great work, @maryjng! You made the changes discussed in the linked issue and used the correct branches in your PR. However, additional changes in _data/internal/credits/website.yml appear to be beyond the scope of the issue. Were these changes part of your good first issue? Maybe your local repo was not up-to-date with the main site before you worked on this second issue? In any case, I would restore the code as it was in that file and make another commit. Let me know what you think!
|
Oh! I see that your good first issue has not yet been merged. We typically wait until our PR is merged before we move on to another issue, but I think keeping this PR will be ok once those changes are removed. |
jyaymie
left a comment
There was a problem hiding this comment.
You've fulfilled the issue's requirements. Approved!
arpitapandya
left a comment
There was a problem hiding this comment.
All the changes are correct! Great job!! @maryjng
Fixes #3401
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website