Skip to content

edit content-field from sustainability.yml credits#3811

Merged
MattPereira merged 2 commits intogh-pagesfrom
unknown repository
Jan 20, 2023
Merged

edit content-field from sustainability.yml credits#3811
MattPereira merged 2 commits intogh-pagesfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 12, 2023

Fixes #2864

What changes did you make and why did you make them ?

  • change content to content-type
  • remove type from line 11

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No images to provide

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Hector-Torres000-edit-content-2864 gh-pages
git pull https://github.com/Hector-Torres000/website.git edit-content-2864

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Jan 12, 2023
@bzzz-coding bzzz-coding self-requested a review January 13, 2023 01:53
@bzzz-coding
Copy link
Member

Availability: Thursday 6-7pm PT
ETA: 6:30pm 1/12/23

@bzzz-coding bzzz-coding self-assigned this Jan 13, 2023
Copy link
Member

@bzzz-coding bzzz-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hector-Torres000 Thanks for working on your first issue!

I see that you updated the content field and deleted the type field on line 11. Well done!

However, I noticed that on line 10, you changed the single quotes to double quotes. This change was not mentioned in issue #3811, and the other yml files have single quotes, so to keep it consistent, I suggest that you change the double quotes back to single quotes for line 10.

@ghost ghost requested a review from bzzz-coding January 14, 2023 00:59
@bzzz-coding
Copy link
Member

@Hector-Torres000 Thank you for submitting this pull request! Everything looks good!

@blulady blulady requested a review from Adaakal January 18, 2023 03:33
@Adaakal
Copy link
Member

Adaakal commented Jan 19, 2023

Availability: 1/20 3-4pm

@Adaakal
Copy link
Member

Adaakal commented Jan 19, 2023

Review ETA: 3 PM 1/21/22

Copy link
Member

@Adaakal Adaakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hector, great job and thank you for working on your first issue!

I see that you updated the content field and deleted the type field on line 11. Well done!
You've also addressed the double quotes on line 10 and you've changed them back to single quotes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from sustainability.yml credits file

4 participants