edit content-field from sustainability.yml credits#3811
edit content-field from sustainability.yml credits#3811MattPereira merged 2 commits intogh-pagesfrom unknown repository
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Thursday 6-7pm PT |
bzzz-coding
left a comment
There was a problem hiding this comment.
@Hector-Torres000 Thanks for working on your first issue!
I see that you updated the content field and deleted the type field on line 11. Well done!
However, I noticed that on line 10, you changed the single quotes to double quotes. This change was not mentioned in issue #3811, and the other yml files have single quotes, so to keep it consistent, I suggest that you change the double quotes back to single quotes for line 10.
|
@Hector-Torres000 Thank you for submitting this pull request! Everything looks good! |
|
Availability: 1/20 3-4pm |
|
Review ETA: 3 PM 1/21/22 |
Adaakal
left a comment
There was a problem hiding this comment.
Hi Hector, great job and thank you for working on your first issue!
I see that you updated the content field and deleted the type field on line 11. Well done!
You've also addressed the double quotes on line 10 and you've changed them back to single quotes. Thank you!
Fixes #2864
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No images to provide