Skip to content

Updated technology.yml#3815

Merged
arpitapandya merged 4 commits intohackforla:gh-pagesfrom
jch1013:remove-type-field-2866
Jan 17, 2023
Merged

Updated technology.yml#3815
arpitapandya merged 4 commits intohackforla:gh-pagesfrom
jch1013:remove-type-field-2866

Conversation

@jch1013
Copy link
Member

@jch1013 jch1013 commented Jan 13, 2023

Fixes #2866

What changes did you make and why did you make them ?

  • Change line 4 for the content field from type:icon to content-type:image
  • Removed line 11

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jch1013-remove-type-field-2866 gh-pages
git pull https://github.com/jch1013/HFLA-website.git remove-type-field-2866

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less status: Updated No blockers and update is ready for review labels Jan 13, 2023
@Adastros Adastros self-requested a review January 17, 2023 06:34
@Adastros
Copy link
Member

Availability (PST): 10:30 - 11:30 PM 16JAN23
Review ETA: 11:30PM 16JAN23

Copy link
Member

@Adastros Adastros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on completing your first issue with Hack for LA!

The only thing I want to note is that for the pull request comment, I think it would help if it also contains a brief explanation about why the changes were implemented. In this case, the reason for the changes are clear from the linked issue.

@arpitapandya arpitapandya merged commit 2dc1092 into hackforla:gh-pages Jan 17, 2023
@jch1013 jch1013 deleted the remove-type-field-2866 branch January 18, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less status: Updated No blockers and update is ready for review

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from technology.yml credits file

3 participants