Skip to content

Edited content field and removed type field from winner.yml file#3816

Merged
blulady merged 1 commit intohackforla:gh-pagesfrom
ychang49265:edit-content-field-#2871
Jan 16, 2023
Merged

Edited content field and removed type field from winner.yml file#3816
blulady merged 1 commit intohackforla:gh-pagesfrom
ychang49265:edit-content-field-#2871

Conversation

@ychang49265
Copy link
Member

Fixes #2871

What changes did you make and why did you make them ?

  • edited the content field from 'content: icon' to 'content-type: image' in the winner.yml file
  • removed the type field 'type: icon' in the winner.yml file

No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ychang49265-edit-content-field-#2871 gh-pages
git pull https://github.com/ychang49265/website.git edit-content-field-#2871

@github-actions github-actions bot added 2 weeks inactive good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less status: Help Wanted Internal assistance is required to make progress labels Jan 14, 2023
@ychang49265 ychang49265 removed status: Help Wanted Internal assistance is required to make progress 2 weeks inactive labels Jan 14, 2023
@ychang49265 ychang49265 self-assigned this Jan 14, 2023
@Jaretzbalba Jaretzbalba self-requested a review January 15, 2023 22:45
@Jaretzbalba
Copy link
Member

Review availability: Sunday 2-3pm
ETA: 01/15 3pm

@Suman2795 Suman2795 self-requested a review January 16, 2023 07:20
@Suman2795
Copy link
Member

Availability: 16/01/2023
ETA: 1 hour

Copy link
Member

@Suman2795 Suman2795 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You linked the correct issue and committed into the correct branch. The changes look good too.
Good work @ychang49265 !

Copy link
Member

@Jaretzbalba Jaretzbalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ychang49265 I see that the content-type and type were updated correctly. Thank you for working on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from winner.yml credits file

4 participants