Skip to content

Edit content field and remove type field from trophy.yml credits file#3832

Merged
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
kyrakwak:change-trophy-yml-fields-2867
Jan 17, 2023
Merged

Edit content field and remove type field from trophy.yml credits file#3832
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
kyrakwak:change-trophy-yml-fields-2867

Conversation

@kyrakwak
Copy link
Member

Fixes #2867

What changes did you make and why did you make them ?

  • Changed content: Image field to content-type: image and removed associated comment
  • Removed type: icon field and associated comment

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to site.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kyrakwak-change-trophy-yml-fields-2867 gh-pages
git pull https://github.com/kyrakwak/website.git change-trophy-yml-fields-2867

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Jan 17, 2023
@jyaymie jyaymie self-requested a review January 17, 2023 15:52
@jyaymie
Copy link
Member

jyaymie commented Jan 17, 2023

Review ETA: 1/17/23 8am
Availability: 1/17/23 Flexible

Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You linked the associated issue, completed its action items, and used the correct branches in your PR. Fantastic work, @kyrakwak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from trophy.yml credits file

3 participants