Display VRMS data on Events and Project Meetings pages

[jyaymie]

Fixes #3701

What changes did you make and why did you make them?

• I added 'if' statements in the insertEventSchedule and display_object functions in assets/js/utility/api-events.js, which fixed TypeErrors caused by incompatible or missing values in the data. Rather than combing through the VRMS data to find what caused these errors, I thought this was a more efficient solution that safeguards against similar issues in the future.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jyaymie-display-vrms-data-3701 gh-pages
git pull https://github.com/jyaymie/website.git display-vrms-data-3701

[MattPereira]

Review ETA: End of Day 1/17/23
Availability: 6-10 PM Tuesday

[t-will-gillis]

Hi jyaymie – Looks good- the /events and /project-meetings pages both seem to be displaying the meeting times correctly, and the individual project pages do not seem to break. I started a tedious exercise comparing the before and after vrms_data.json files. As Matt already pointed out, there are a couple dozen lines of code that were deleted in ‘testy test Team Meeting’ that were previously included in project: and now are null, which may have been the breakpoint.
I am marking my review as ‘approved’ - I have nothing to add to Matt’s or your insights, but I will be following along to see how the two of you resolve this.
Great job moving this forward.

[MattPereira]

Moving this bug discovery log out of "resolved conversation" for future reference:

After console.logging the responseData and using a try...catch block around the rv_object instantiation, it appears that the very last meeting time is a test that was breaking everything because the project property is set to null.

[MattPereira]

@jyaymie nice work knocking down a large time-sensitive issue so quickly! 💪

Appreciate your explanation of the proposed changes and the quality screenshots.

My only tiny suggestion is to use the check boxes provided under the issue action items, but I have seen lots of other developers here not using them so maybe I just have a weird thing for check marks 🤔

[jyaymie]

My only tiny suggestion is to use the check boxes provided under the issue action items, but I have seen lots of other developers here not using them so maybe I just have a weird thing for check marks 🤔

Good call, @MattPereira. Those boxes are there for a reason!