Skip to content

edited and removed field#3842

Merged
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
brianf4:edit-and-remove-field-2869
Jan 19, 2023
Merged

edited and removed field#3842
arpitapandya merged 1 commit intohackforla:gh-pagesfrom
brianf4:edit-and-remove-field-2869

Conversation

@brianf4
Copy link
Member

@brianf4 brianf4 commented Jan 19, 2023

Fixes #2869

What changes did you make and why did you make them ?

  • Updated _data/internal/credits/video-conference.yml
  • Changed line 4 from
content: icon

to

content-type: image

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Moving files to another directory. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b brianf4-edit-and-remove-field-2869 gh-pages
git pull https://github.com/brianf4/website.git edit-and-remove-field-2869

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Jan 19, 2023
@brianf4
Copy link
Member Author

brianf4 commented Jan 19, 2023

Deleted line 11 as well.

@roslynwythe roslynwythe self-requested a review January 19, 2023 06:43
@roslynwythe
Copy link
Member

Availability: 1/18 until midnight; 1/19 11am - noon

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branches are correct, your code changes are perfect, and the testing of your branch demonstrated that the credits page displays the icon and text with no problem. Great job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from video-conference.yml credits file

3 participants