Update sdg img size and .sustainable-dev-goal padding#3844
Update sdg img size and .sustainable-dev-goal padding#3844jdingeman merged 3 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: EOD 1/24 |
There was a problem hiding this comment.
Hello. Nice job on this. The SDG images are sized correctly and padding looks good.
However in reading the issue, I believe the padding between cards should also be increased. It looks like in the published website and your current layout have a margin of 14px between cards:
It looks like the figma design is proposing a margin of 30px between each card:
|
Thank you. I'll fix that card padding. |
|
Hi @SZwerling, just wanted to check in to see if you are still working on this issue and could provide a progress update? If we don't hear back by Monday, we are going to close this pull request. |
|
Hello, @jdingeman. Apologies for delayed response. |
|
Hey @SZwerling , sorry about that, I see that you had pushed the commits prior to my comment. I will rereview. |
|
ETA: EOD 2/13 |
Jaretzbalba
left a comment
There was a problem hiding this comment.
@SZwerling I see the changes to the padding and margin on the $bp-tablet-up media query reflect the new figma design. Everything looks to be uniform now and spaced as requested. Thank you for working on this issue!



Fixes #3738
What changes did you make and why did you make them ?
-All changes within $bp-media-up media query.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
.pdf
)