Edit content field 2806#3961
Conversation
…update-alt-text-3872
…edit-content-field-2806
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Review ETA: 6 PM ET 02/11/2023 Sat |
|
Review ETA 7:15PM PT Fri, 2/10/2023 |
angelenelm
left a comment
angelenelm
left a comment
There was a problem hiding this comment.
Addresses the tasks needed to be done in issue #2806, well done! :)
MarkWiltberger
left a comment
MarkWiltberger
left a comment
There was a problem hiding this comment.
Great job! I love what you have done, @Thinking-Panda!
The pull request is done with the correct branch and links the correct issue.
Do the changes pass the ABC's:
A - Applicable: Pass, the changes apply to the linked issue.
B - Does not Break the main website: Pass, the change branch was incorporated in the local site using Docker and the main website did not break. As expected, the fix of this issue does not result in visible changes to the website. Code was inspected and the changes are present.
C - Clean: Changes requested. I noticed that there is an empty line where the type field was. It appears from the other credit files, the convention is not to have any empty lines between the dashed lines in the markdown file, and the original issue also requests that this line be deleted. Please delete this line, as marked in the inline comment, to make the code more Clean and condensed.
Other than that, it looks great! Well Done, @Thinking-Panda !
MarkWiltberger
added
the
status: Help Wanted
|
Looks good if you remove the extra line at the end of the |
MarkWiltberger
removed
the
status: Help Wanted
|
I have made the correction mentioned. Please review the request. |
|
Review ETA: 5pm today. |
chrismenke45
left a comment
chrismenke45
left a comment
There was a problem hiding this comment.
Looks good! You have completed what was requested and removed the extra line @MarkWiltberger noticed. Good work!
|
2nd review after changes: |
Thinking-Panda
requested review from
MarkWiltberger,
angelenelm and
chrismenke45
MarkWiltberger
left a comment
MarkWiltberger
left a comment
There was a problem hiding this comment.
Looks good! Code was inspected on local machine. You completed what was requested and removed the empty line of code from check.yml. 👍
angelenelm
left a comment
angelenelm
left a comment
There was a problem hiding this comment.
Approved, thanks everyone for pointing out the empty line :)
6 participants
Fixes #2806
What changes did you make and why did you make them ?
-Edited content field.
-Changed it to "content-type: image"
-Removed the Type field
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visible change to website