Skip to content

Add link to project header 3802#4027

Merged
MattPereira merged 4 commits intohackforla:gh-pagesfrom
Thinking-Panda:add-link-to-project-header-3802
Feb 24, 2023
Merged

Add link to project header 3802#4027
MattPereira merged 4 commits intohackforla:gh-pagesfrom
Thinking-Panda:add-link-to-project-header-3802

Conversation

@Thinking-Panda
Copy link
Member

Fixes #3802

What changes did you make and why did you make them ?

  • Added link to the project header. The project header appears with an underline and clicking on it take you to the project details page.
  • Link is added dynamically so the code works for any new projects added in future.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Before_changes_to_header

Visuals after changes are applied

Link_Added

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Thinking-Panda-add-link-to-project-header-3802 gh-pages
git pull https://github.com/Thinking-Panda/website.git add-link-to-project-header-3802

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Medium P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement size: 1pt Can be done in 4-6 hours labels Feb 23, 2023
@roslynwythe roslynwythe self-requested a review February 23, 2023 08:44
@roslynwythe
Copy link
Member

Availability: 2/23 4 - 7 pm
ETA 2/24

@roslynwythe
Copy link
Member

Hi @Thinking-Panda, thank you for working on this issue. Your branch includes commits to green-earth-os.md which are not relevant to this issue. I will consult with the merge team to determine how to proceed.

@Thinking-Panda
Copy link
Member Author

Thankyou @roslynwythe!

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Thinking-Panda, the branches are setup correctly, the code is correct and clean and checks out fine in the browser. Thank you for completing this issue!

@MattPereira MattPereira self-requested a review February 24, 2023 22:49
@MattPereira
Copy link
Contributor

Availability: 7 - 9 PM Sunday - Thursday
ETA: 30 minutes

Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @Thinking-Panda

Love the variable name project_relative_path 👍

@MattPereira MattPereira merged commit b25e370 into hackforla:gh-pages Feb 24, 2023
@Thinking-Panda Thinking-Panda deleted the add-link-to-project-header-3802 branch February 25, 2023 00:59
@Thinking-Panda
Copy link
Member Author

Thank you for all your help, @MattPereira !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Citizen Engagement page: Add links to each red project header

3 participants