Renamed citizen engagement file#4205
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
role: front end
|
Review ETA: End of day today |
bootcamp-brian
left a comment
bootcamp-brian
left a comment
There was a problem hiding this comment.
Good job getting the branches set up right and the issue linked as well as making all the requested changes from the issue. The only thing I would change is that I would add the changes you made inside the _includes/program-area-pages-cards.html file to your list of you made in your pull request comment.
|
@bootcamp-brian Thanks! I've updated my PR. |
bootcamp-brian
left a comment
bootcamp-brian
left a comment
There was a problem hiding this comment.
Everything looks good now. Great job!
oliviazhai
left a comment
oliviazhai
left a comment
There was a problem hiding this comment.
this looks good to me!
There was a problem hiding this comment.
Hey @arcan9 - Great job on this issue! Your from and to branches are correct, and you addressed the requirements of the issue. And you made the changes to the description working with @bootcamp-brian - good teamwork! I also checked on Docker and the /citizen-engagement page seems to be working as before. Your code is clean and you changed only what needed to be changed- nothing appears broken.
Great job again-
|
As a reminder, there is one additional item to change the wiki, shown on #3756 , to be done after this is merged. Thanks for your work! |
4 participants
Fixes #3756
What changes did you make and why did you make them ?
_includes, renamed thecitizen-engagement-cards.htmltoprogram-area-pages-cards.htmlso that the name of the file reflects the purpose of the card better._includes/program-area-pages-cards.html, a new comment has been added to clarify what the elements in that file are:pages/citizen-engagement.html, this lineis changed to
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Only the file name and the markup were changed. No visual changes to the website. Looks good on desktop, tablet and mobile, and functions like before.