edit content field and remove type field from group.yml credits file#4273
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Review ETA: 9 PM 3/25/22 |
janice87
left a comment
janice87
left a comment
There was a problem hiding this comment.
The pull request is done in the correct branch and the issue is linked correctly. It follows the ABCs and the issue is addressed and updated. The change does not affect the physical appearance of the website. The only suggestion I have is to have the title of the PR be more descriptive and related to the issue, otherwise everything looks good!
t-will-gillis
left a comment
t-will-gillis
left a comment
There was a problem hiding this comment.
Hi @vincentdang - great job on this issue! The branches from and to are correct, you linked the issue correctly, and you made the changes requested by the issue. As @janice87 mentioned, it would be helpful if you could edit the title of the issue to be more descriptive of the issue. This helps us when looking through the pull requests, etc. Something simple would work such as 'Update and edit to group.yml' . It also would be helpful to add more to the description. You can usually look at the original issue's Overview section to get an idea, for example '...edited the content field and removed the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.'
Thanks for you work on this!
|
@vincentdang Please change the name of the PR to |
vincentdang
changed the title
hi thanks for your feedback. I have done what is requested. |
4 participants
Fixes #2833
I changed line 4 from content: icon to content-type: images and deleted line 11 to remove redundancy.