moved SDG folder and refactored SDG paths in multiple files

[arcan9]

Fixes #4183

What changes did you make and why did you make them ?

• sdg-elements directory is renamed to sdg and moved up one level.
  • Old path: assets/images/about/sdg-elements
  • New path: assets/images/sdg
• Due to the change, various files had to be refactored to point to the new path (listed in the issue).
• Reason: to accurately reflect that we use these SDG images on multiples pages of the HfLA website

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Small card images in the "sustainable" sections in mulitple project pages:

Visuals after changes are applied

After the change, the images are still rendered correctly:

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b arcan9-modify-sdg-and-associated-refactoring-4183 gh-pages
git pull https://github.com/arcan9/website.git modify-sdg-and-associated-refactoring-4183

[nnr-nnr]

Review ETA: EOD Mon. 3/27/23
Availability: 12-4 PM 3/26, 3-8 PM 3/27–328/

[richardmundyiii]

Availability: 3/26/23 12pm - 3pm
ETA: EOD 3/26/23

[nnr-nnr]

Wonderful work, @arcan9 ! You've cleanly moved and renamed all the SDG image assets, and you've updated all mentions of these files in the repo to reflect these changes. This PR passes the ABCs 👍.

[arcan9]

Availability: 3/26/23 12pm - 3pm ETA: EOD 3/26/23

Hi @richardmundyiii are you still available to review this?

[blulady]

@arcan9 All the changes you have done look great!!! However when I pull your branch into my local and search for "assets/images/about/sdg-elements", I find 18 mentions of it in 7 files. I see it in citzen-engagement.html, about\index.html, 311-data.html, access-the-data.html, engage.html, lucky-parking.html and open-community-survey.html. Please update the branch with changes to assets/images/sdg-elements from assets/images/about/sdg-elements.

[nnr-nnr]

Hi @blulady, just curious how you found the mentions of assets/images/about/sdg-elements? In VS Code, I use the Cmd + Shift + F (on mac) sequence to search for "assets/images/about/sdg-elements", but this doesn't turn up any mentions. I'm also not seeing the mentions of this file path in the files you listed, though I do see the updated file path that Issue #4183 says to use (ie assets/images/sdg). I think I might be missing something here... Thank you!

[arcan9]

@blulady: Like @nnr-nnr, I can't seem to find any mentions of assets/images/about/sdg-elements in the files you mentioned. And interestingly, I couldn't find those html files. Could you clarify please? Thank you.

[arcan9]

@t-will-gillis @bzzz-coding @roslynwythe Would love feedback on this!

[t-will-gillis]

Hey @arcan9 - Great job! Your branches are correct, as is your linked issue, and your description is super with the clips. I checked the changes on Docker and did not see any unexpected changes. Also did a final check and it appears that all assets/images/about/sdg-elements paths are changed.

Thanks for your efforts and great job again

[blulady]

Hey @arcan9 - Great job! Your branches are correct, as is your linked issue, and your description is super with the clips. I checked the changes on Docker and did not see any unexpected changes. Also did a final check and it appears that all assets/images/about/sdg-elements paths are changed.

Thanks for your efforts and great job again

Hey @t-will-gillis feel free to merge this pr.

Please see comments above

[t-will-gillis]

Merge conflicts have been resolved.