Skip to content

Edit content field and remove type field from environmental-impact.yml#4346

Merged
christinaor merged 1 commit intohackforla:gh-pagesfrom
StephenTheDev1001:edit-content-remove-type-2830
Apr 3, 2023
Merged

Edit content field and remove type field from environmental-impact.yml#4346
christinaor merged 1 commit intohackforla:gh-pagesfrom
StephenTheDev1001:edit-content-remove-type-2830

Conversation

@StephenTheDev1001
Copy link
Contributor

@StephenTheDev1001 StephenTheDev1001 commented Mar 30, 2023

Fixes #2830

What changes did you make and why did you make them ?

  • change content field to content-type: image for clarity of purpose
  • remove type field to remove redundancy with content field

Screenshots of Proposed Changes Of The Website

Moving files to another directory. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b StephenTheDev1001-edit-content-remove-type-2830 gh-pages
git pull https://github.com/StephenTheDev1001/website.git edit-content-remove-type-2830

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Credit https://www.hackforla.org/credits/ size: 0.5pt Can be done in 3 hours or less labels Mar 30, 2023
@perlaroyerc perlaroyerc self-requested a review March 30, 2023 15:54
@perlaroyerc
Copy link
Member

Availability: 11-7 ET M-F
ETA: EOD 3/30

@LOSjr4 LOSjr4 self-requested a review March 30, 2023 17:15
@LOSjr4
Copy link
Member

LOSjr4 commented Mar 30, 2023

availability: mon, tues, thurs 9AM-1PM
eta: 03/30/2023 noon

Copy link
Member

@LOSjr4 LOSjr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good Stephen. Although your description says you changed content-type: icon instead of image, you did make the correct changes in the code.

Copy link
Member

@perlaroyerc perlaroyerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job working on your first issue @StephenTheDev1001! The changes look good in the local environment, the issue was linked, and the branches are correct.

I suggest a few minor edits:

  • As Luis mentioned above, you should edit the PR description to the correct content-type image.
  • Add a brief description explaining "why" you made the changes, as it helps ensure the changes align with the project's goals and the HFLA guidelines.
  • If no visual changes were made, add an explanation for no images like: No visual changes made.

Copy link
Member

@perlaroyerc perlaroyerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job addressing the requested changes!

@christinaor
Copy link
Member

Thanks for working on this issue Stephen! I can see the changes made on line 4 and the deletion of line 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from environmental-impact.yml credits file

4 participants