Skip to content

add sdg scss color vars and import to main#4404

Merged
jdingeman merged 1 commit intohackforla:gh-pagesfrom
StephenTheDev1001:sdg-color-vars-4233
Apr 4, 2023
Merged

add sdg scss color vars and import to main#4404
jdingeman merged 1 commit intohackforla:gh-pagesfrom
StephenTheDev1001:sdg-color-vars-4233

Conversation

@StephenTheDev1001
Copy link
Contributor

@StephenTheDev1001 StephenTheDev1001 commented Apr 4, 2023

Fixes #4233

What changes did you make and why did you make them ?

  • create new file _colors-sdg.scss with sdg-color variables
  • import _colors-sdg.scss to _sass/main.scss
  • allows us to use these colors with their corresponding, matching SDG icons.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Added scss background color variables. No visual changes.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b StephenTheDev1001-sdg-color-vars-4233 gh-pages
git pull https://github.com/StephenTheDev1001/website.git sdg-color-vars-4233

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Apr 4, 2023
@StephenTheDev1001 StephenTheDev1001 marked this pull request as ready for review April 4, 2023 06:04
@Jaretzbalba Jaretzbalba self-requested a review April 4, 2023 20:08
@Jaretzbalba
Copy link
Member

Review ETA: 4/5/23
Availability: 1 hour

@StephenTheDev1001 StephenTheDev1001 changed the title add sdg scss color vals and import to main add sdg scss color vars and import to main Apr 4, 2023
Copy link
Member

@Jaretzbalba Jaretzbalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenTheDev1001 I see that the main.css file was updated and the new file containing the sdg colors was created successfully. Everything looks good to me! Thank you for working on this issue!

@LOSjr4 LOSjr4 self-requested a review April 4, 2023 22:36
@LOSjr4
Copy link
Member

LOSjr4 commented Apr 4, 2023

Availability: tues, fri, mon
ETA: 4/4 4:30PM

Copy link
Member

@LOSjr4 LOSjr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New file in the correct folder, correct info added to file, and added line to main.scss. Yes, yes, and yes. Good work @StephenTheDev1001 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SDG color variables: 2-5, 8-11, 13, 16, 17

4 participants