Skip to content

Created a sdg folder (\_data\internal\sdg), and a sdg11.yml file inside that folder (\_data\internal\sdg\sdg11.yml)#4408

Merged
jdingeman merged 1 commit intohackforla:gh-pagesfrom
LOSjr4:create-yml-SDG11-4293
Apr 6, 2023
Merged

Created a sdg folder (\_data\internal\sdg), and a sdg11.yml file inside that folder (\_data\internal\sdg\sdg11.yml)#4408
jdingeman merged 1 commit intohackforla:gh-pagesfrom
LOSjr4:create-yml-SDG11-4293

Conversation

@LOSjr4
Copy link
Member

@LOSjr4 LOSjr4 commented Apr 4, 2023

Fixes #4293

What changes did you make and why did you make them ?

  • We want to create a yml file for a Sustainable Development Goal (SDG) so that information is not repeated in multiple files
  • Inside _data/internal/, I created a folder named "sdg"
  • Inside of that folder (_data/internal/sdg), I created a file named "sdg11.yml"
  • On that file I copy/pasted in the input as written in the issue.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

This addition does not currently create a visual change.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b LOSjr4-create-yml-SDG11-4293 gh-pages
git pull https://github.com/LOSjr4/website.git create-yml-SDG11-4293

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Apr 4, 2023
@KazushiR KazushiR self-requested a review April 4, 2023 22:19
@KazushiR
Copy link
Member

KazushiR commented Apr 4, 2023

Availability: Weekdays
ETA: EOD today

@arcan9 arcan9 self-requested a review April 5, 2023 02:26
@arcan9
Copy link
Member

arcan9 commented Apr 5, 2023

Review ETA: EOD 04/05
Availability: after 6pm PST, M-F

Copy link
Member

@KazushiR KazushiR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. Apologies on the late review. After looking through your changes, everything looks good!

@jefflueck jefflueck self-requested a review April 5, 2023 21:26
@jefflueck
Copy link
Member

Availability: Wed, Fri 12 - 6 CST
ETA: Today

Copy link
Member

@jefflueck jefflueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the changes, and it looks good.
Nice work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a yml file for SDG 11

5 participants