Skip to content

SDG 2: Rename and replace image with correct color one#4443

Merged
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
cng008:replace-image-4254
Apr 11, 2023
Merged

SDG 2: Rename and replace image with correct color one#4443
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
cng008:replace-image-4254

Conversation

@cng008
Copy link
Member

@cng008 cng008 commented Apr 8, 2023

Fixes #4254

What changes did you make and why did you make them ?

  • Replaced the Sustainable Development Goals (SDG) images in the repository so that the SDG svgs are the correct color and follow the United Nations' SDG guidelines (after image is slightly lighter in color)
    • Deleted zero-hunger.svg
    • Added the svg into the assets/images/sdg directory

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

before

Visuals after changes are applied

after

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b cng008-replace-image-4254 gh-pages
git pull https://github.com/cng008/website.git replace-image-4254

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: About Us https://www.hackforla.org/about/ Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Apr 8, 2023
@KazushiR KazushiR self-requested a review April 8, 2023 05:09
@KazushiR
Copy link
Member

KazushiR commented Apr 8, 2023

Availability: weekdays
ETA: Will look it over by EOD tomorrow 04/08/2023

@Jaretzbalba Jaretzbalba self-requested a review April 8, 2023 17:06
@Jaretzbalba
Copy link
Member

Jaretzbalba commented Apr 8, 2023

Availability: 1 hour
ETA: EOD 4/8

Jaretzbalba
Jaretzbalba approved these changes Apr 8, 2023
View reviewed changes
Copy link
Member

@Jaretzbalba Jaretzbalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cng008 I see that the old image was deleted and replaced with the new one in accordance with SDG guidelines. Everything looks good to me! Thank you for working on this issue!

KazushiR
KazushiR approved these changes Apr 9, 2023
View reviewed changes
Copy link
Member

@KazushiR KazushiR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cng008 Hello. Apologies on the late reply. After reviewing the PR, everything looks good!

@roslynwythe roslynwythe merged commit 6f15f8b into hackforla:gh-pages Apr 11, 2023
This was referenced Aug 10, 2025
Closed
Closed
Closed
@t-will-gillis t-will-gillis mentioned this pull request Aug 22, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@KazushiR KazushiR KazushiR approved these changes

@Jaretzbalba Jaretzbalba Jaretzbalba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SDG 2: Rename and replace image with correct color one

4 participants

@cng008 @KazushiR @Jaretzbalba @roslynwythe