Img tag refactor citizen engagement 4446#4453
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: EOD 04/09 |
arcan9
left a comment
There was a problem hiding this comment.
Good job @DeitchDustin!
- You made the changes that were outlined in the issue
- Made in the correct branch
- Linked issue
- Stated reason for the change
|
Review ETA: EOD 04/09 |
steven-positive-tran
left a comment
There was a problem hiding this comment.
Good job the issue has been done and you have commited to the right branch.
I do see that 2 lines have been changed that wasn't in the scope where you removed a space in header-hero alt for the citizen-engagement.html and added a space for the join-us.html alt and I don't see to do that in the linked issue.
I think the merge team could just merge this pull request but they might ask to fix that issue.
steven-positive-tran
left a comment
There was a problem hiding this comment.
Thanks for fixing that issue.


Fixes #4446
What changes did you make and why did you make them ?
Removed ending '/ ' in img HTML tag with class 'org-img org-img-large' to make codebase to be consistent with how HackForLA uses img HTML tags.
Did not remove ending '/' for HTML tag with class of 'header-hero-image' as ticket did not call for this to be fixed.