Skip to content

Img tag refactor citizen engagement 4446#4453

Merged
jdingeman merged 3 commits intogh-pagesfrom
unknown repository
Apr 13, 2023
Merged

Img tag refactor citizen engagement 4446#4453
jdingeman merged 3 commits intogh-pagesfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Apr 9, 2023

Fixes #4446

What changes did you make and why did you make them ?

  • Removed ending '/ ' in img HTML tag with class 'org-img org-img-large' to make codebase to be consistent with how HackForLA uses img HTML tags.

  • Did not remove ending '/' for HTML tag with class of 'header-hero-image' as ticket did not call for this to be fixed.

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b DeitchDustin-img-tag-refactor-Citizen-Engagement-4446 gh-pages
git pull https://github.com/DeitchDustin/website.git img-tag-refactor-Citizen-Engagement-4446

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Refactor HTML P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 9, 2023
@arcan9 arcan9 self-requested a review April 9, 2023 18:28
@arcan9
Copy link
Member

arcan9 commented Apr 9, 2023

Review ETA: EOD 04/09
Availability: 3-5pm PST, 04/09

arcan9
arcan9 previously approved these changes Apr 10, 2023
Copy link
Member

@arcan9 arcan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @DeitchDustin!

  • You made the changes that were outlined in the issue
  • Made in the correct branch
  • Linked issue
  • Stated reason for the change

@steven-positive-tran
Copy link
Member

Review ETA: EOD 04/09
Availability: 10-12pm PST, 04/09

@steven-positive-tran steven-positive-tran self-requested a review April 10, 2023 05:25
Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job the issue has been done and you have commited to the right branch.

I do see that 2 lines have been changed that wasn't in the scope where you removed a space in header-hero alt for the citizen-engagement.html and added a space for the join-us.html alt and I don't see to do that in the linked issue.

I think the merge team could just merge this pull request but they might ask to fix that issue.

image
image

Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Refactor HTML good first issue Good for newcomers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Citizen Engagement page

3 participants