Skip to content

SDG 17: Rename and Replace Partnerships for the Goals svg#4467

Merged
jdingeman merged 2 commits intohackforla:gh-pagesfrom
karengcecena:rename-and-replace-sdg17-svg-4258
Apr 13, 2023
Merged

SDG 17: Rename and Replace Partnerships for the Goals svg#4467
jdingeman merged 2 commits intohackforla:gh-pagesfrom
karengcecena:rename-and-replace-sdg17-svg-4258

Conversation

@karengcecena
Copy link
Member

Fixes #4258

What changes did you make and why did you make them ?

  • Deleted partnerships.svg from assets/images/sdg
  • Downloaded the new E-WEB-Goal-17.svg and renamed it to sdg17.svg so that the SDG svgs are the correct color and follow the United Nations' SDG guidelines.
  • Added sdg17.svg to assets/images/sdg

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-04-11 at 10 48 24 AM
Visuals after changes are applied Screenshot 2023-04-11 at 10 40 02 AM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b karengcecena-rename-and-replace-sdg17-svg-4258 gh-pages
git pull https://github.com/karengcecena/website.git rename-and-replace-sdg17-svg-4258

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: About Us https://www.hackforla.org/about/ Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Apr 11, 2023
@Jaretzbalba Jaretzbalba self-requested a review April 11, 2023 18:15
@Jaretzbalba
Copy link
Member

Review ETA: EOD 4/11/23
Availability: 1 hour

Copy link
Member

@Jaretzbalba Jaretzbalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karengcecena I see that the svg image for the Partnerships for the Goals was replaced correctly and looks good on my local machine. Goob job working on this issue!

@arcan9 arcan9 self-requested a review April 11, 2023 19:30
@arcan9
Copy link
Member

arcan9 commented Apr 11, 2023

Review ETA: EOD 04/12
Availability: afternoon PST, M-F

@janice87 janice87 self-requested a review April 11, 2023 20:17
@janice87
Copy link
Member

Review ETA: 04/12 EOD
Availability: 4/11 & 4/12 5-9PM

Copy link
Member

@janice87 janice87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request is done in the correct branch and the issue is linked correctly. I see that the partnerships svg is deleted and sdg17 is added in the correct directory. The visual changes are reflected and shows up in the same spot as the live webpage. Great job on this issue!

@karengcecena karengcecena changed the title Rename and Replace Partnerships for the Goals svg SDG 17: Rename and Replace Partnerships for the Goals svg Apr 12, 2023
Copy link
Member

@arcan9 arcan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @karengcecena!

  • You made the changes that were outlined in the issue
  • Made in the correct branch
  • Linked issue
  • Stated reason for the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDG 17: Rename and replace image with correct color one

5 participants