Skip to content

sdg 5 - rename and replace image with correct color one#4472

Merged
jdingeman merged 1 commit intohackforla:gh-pagesfrom
thedvo:sdg-5-rename-replace-image-4255
Apr 13, 2023
Merged

sdg 5 - rename and replace image with correct color one#4472
jdingeman merged 1 commit intohackforla:gh-pagesfrom
thedvo:sdg-5-rename-replace-image-4255

Conversation

@thedvo
Copy link
Member

@thedvo thedvo commented Apr 12, 2023

Fixes #4255

What changes did you make and why did you make them ?

  • navigated to assets/images/sdg directory, delete gender-equality.svg
  • added sdg5.svg file to assets/images/sdg
  • updated the path to the SVG in the website about page sustainability section

Screenshots of Proposed Changes Of The Website

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b thedvo-sdg-5-rename-replace-image-4255 gh-pages
git pull https://github.com/thedvo/website.git sdg-5-rename-replace-image-4255

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: About Us https://www.hackforla.org/about/ Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Apr 12, 2023
@KazushiR KazushiR self-requested a review April 12, 2023 01:57
Copy link
Member

@KazushiR KazushiR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing this, it looks like everything looks good!

@karengcecena karengcecena self-requested a review April 12, 2023 15:04
@karengcecena
Copy link
Member

Review ETA: 9am 04/12
Availability: 8 - 9am

Copy link
Member

@karengcecena karengcecena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thedvo. Thank you for taking the time to complete this issue. Your pull request is to and from the correct branches, you linked the issue correctly, you removed and added the correct svg’s, you updated the path to the svg correctly and the website looks good on my local machine.

Great job & thanks again for working on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDG 5: Rename and replace image with correct color one

4 participants