Added workflow_dispatch: (with colon) for a manual workflow trigger.#4501
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 9 PM 4/15/22 |
blulady
left a comment
There was a problem hiding this comment.
This PR comes from the correct branch and goes to the correct branch. Properly addresses the correctly linked issue by adding a manual trigger in addition to the cron job that was already running.
I was able to test if this worked by pulling the branch into my local, pushing it into my own personal GitHub repository, switching the default branch to LOSjr4's branch, clicking on actions in the second navbar from the top, clicking on Update VRMS Data on the left side navbar, and seeing that there was a Run Workflow button to the right under workflow runs. I didn't make the changes necessary to the file to run it in my local repo but the button was there.
Good Job!!
|
Also, thank you for all the reviews you've been leaving on other folk's PRs. As soon as @janice87 gets a chance to review this, I hope it gets merged. |
janice87
left a comment
There was a problem hiding this comment.
The pull request is done in the correct branch and the issue is linked correctly. In the vrms-data.yml file I see the workflow dispatch was added. I went into my own GitHub repo, went to your branch and under Actions I see the workflow "Update VRMS data". When I press on the workflow, it says it is disabled by default in forks, but like Matt mentioned this is expected due to the token. From what I can see, it looks like the issue was addressed. Great job on this issue!
Fixes #4392
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Backend only, no visual changes on website. There may be changes as a github action. I followed Matt Pereira's instructions on the comment section of the original issue to try to test changes, but I'm uncertain and as Matt said, "The action is going to fail on your fork because one of the steps uses a token".