Skip to content

Created a yml file for SDG2#4548

Merged
blulady merged 1 commit intohackforla:gh-pagesfrom
agosmou:agomez-create-yml-SDG2-4450
Apr 20, 2023
Merged

Created a yml file for SDG2#4548
blulady merged 1 commit intohackforla:gh-pagesfrom
agosmou:agomez-create-yml-SDG2-4450

Conversation

@agosmou
Copy link
Member

@agosmou agosmou commented Apr 19, 2023

Fixes #4450

What changes did you make and why did you make them ?

  • Added a yml file for a Sustainable Development Goal no. 2 (SDG2) so that information is not repeated in multiple files

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes.

@agosmou agosmou self-assigned this Apr 19, 2023
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b agosmou-agomez-create-yml-SDG2-4450 gh-pages
git pull https://github.com/agosmou/website.git agomez-create-yml-SDG2-4450

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Apr 19, 2023
@Thinking-Panda Thinking-Panda self-requested a review April 19, 2023 20:33
@Thinking-Panda
Copy link
Member

Availability: M-F 10 AM - 3PM
ETA: 4/20/23

@mjshelton12 mjshelton12 self-requested a review April 19, 2023 21:45
@mjshelton12
Copy link
Member

Review Availability: Wed 7pm-10pm, Thur 9am-1pm
ETA: EOD 4/19/23

Copy link
Member

@mjshelton12 mjshelton12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, agosomou! The basics are done perfectly: Your branches are correct, you linked to your issue, and your explanation of what you did and why you did it is clear.

Your code is clean and effectively meets the needs of the issue. Though it doesn't affect the look of the site, I brought it up in docker just incase and the site is indeed unchanged in all views. Excellent work!

@StephenTheDev1001 StephenTheDev1001 self-requested a review April 20, 2023 00:20
@StephenTheDev1001
Copy link
Contributor

Availability: M-F 10am - 12pm
ETA: EOD 4/19/23

Copy link
Contributor

@StephenTheDev1001 StephenTheDev1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pull request. You created the correct file and added the code correctly. I appreciate your clear and concise description of the changes made and why they were necessary. Thank you for your contribution.

Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @agosmou , Thank you for working on this issue. Merge branches look perfect, code added is clean and website works perfect on the local machine. Well done!

Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is coming from the correct branch and going into gh-pages. There is a linked issue, it is correct and addressed in the PR by creating file sdg2.yml in the correct directory. The code is identical to the code in the linked issue. The code looks clean, only one commit and only one file changed.
Good job!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a yml file for SDG 2

5 participants