Skip to content

Created YML file for SDG 3#4549

Merged
blulady merged 1 commit intohackforla:gh-pagesfrom
se7en-illa:create-yml-sdg3-4451
Apr 20, 2023
Merged

Created YML file for SDG 3#4549
blulady merged 1 commit intohackforla:gh-pagesfrom
se7en-illa:create-yml-sdg3-4451

Conversation

@se7en-illa
Copy link
Member

@se7en-illa se7en-illa commented Apr 20, 2023

Fixes #4451

What changes did you make and why did you make them ?

  • Created YML file for Sustainable Development Goal 3 (SDG3) so that information is not repeated in multiple files

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b se7en-illa-create-yml-sdg3-4451 gh-pages
git pull https://github.com/se7en-illa/website.git create-yml-sdg3-4451

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Apr 20, 2023
@StephenTheDev1001 StephenTheDev1001 self-requested a review April 20, 2023 03:07
@StephenTheDev1001
Copy link
Contributor

Availability: M-F 10am-12pm
Review ETA: EoD Apr 19th

Copy link
Contributor

@StephenTheDev1001 StephenTheDev1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You created a new file correctly and followed the naming convention. You also did the pull request on the correct branch and wrote a clear and concise description of the changes you made and why they were necessary. Well done!

@kwangric kwangric self-requested a review April 20, 2023 16:14
@kwangric
Copy link
Member

ETA: EOD 4/20
Availability: Before 2pm PDT today

Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches were set up correctly. The file was created in the right location with the correct information and the pull request included a description of the changes made. Great work!

Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is coming from the correct branch and going into gh-pages. There is a linked issue, it is correct and addressed in the PR by creating file sdg3.yml in the correct directory. The code is identical to the code in the linked issue. The code looks clean, only one commit and only one file changed.
Good job!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a yml file for SDG 3

4 participants