Skip to content

removed Bitian Zhang & Arpita Pandya#4643

Closed
93Belen wants to merge 1 commit intohackforla:gh-pagesfrom
93Belen:gh-pages
Closed

removed Bitian Zhang & Arpita Pandya#4643
93Belen wants to merge 1 commit intohackforla:gh-pagesfrom
93Belen:gh-pages

Conversation

@93Belen
Copy link
Member

@93Belen 93Belen commented May 9, 2023

Fixes #4473

What changes did you make and why did you make them ?

I removed Bitian Zhang and Arpita Pandya from the leadership in Hackforla.org Website

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied before changes
Visuals after changes are applied first isssue

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b 93Belen-gh-pages gh-pages
git pull https://github.com/93Belen/website.git gh-pages

@steven-positive-tran
Copy link
Member

Avail: Tue, Thurs 7pm-12
ETA: Tue 11pm

@steven-positive-tran steven-positive-tran self-requested a review May 10, 2023 01:16
@blulady blulady requested review from bphan002 and mademarc May 10, 2023 02:21
@bphan002
Copy link
Member

Avail: Wed
ETA: Wed 3 PM PST

Copy link
Member

@bphan002 bphan002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Belen it looks like you made the correct changes needed, but didn't do it on a new branch. This is my first PR review, so I'll wait for the second reviewer to chime in on if this should be done. Or you can go ahead and make a new branch for the changes.

Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its best practice for it to be on a seperate branch. We want to keep the gh-pages in the form to be exactly like the branch from main.

@93Belen
Copy link
Member Author

93Belen commented May 10, 2023

Ok! I had to do a different pull request in order to change the Head branch the pull request was done from. Here is the new one: #4646.
Thank you!

@Adastros
Copy link
Member

Closing this pull request since a new one was made. See #4646.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Project Profile: HackforLA.org Website

4 participants