Update labels within pre-work-template---ex.md file

[arfgit]

Fixes #4484

What changes did you make and why did you make them ?

• Replace the following line labels: 'Feature: Onboarding/Contributing.md, prework, role: user research, size:1pt' with label: ['Feature: Onboarding/Contributing.md','prework','role: user research','size:1pt','Complexity: Missing']
• File was located in .github/ISSUE_TEMPLATE/pre-work-template---ux.md
• Changes were made to kick off my first good issue

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b arfgit-update-labels-4484 gh-pages
git pull https://github.com/arfgit/website.git update-labels-4484

[kerimedeiros]

ETA: EOD today
Availability: M-F 9am-5pm

[kerimedeiros]

Branch is set up correctly and linked issue is accurate. The code changes are correct. No screenshots required here, as change was to a markdown file only (would recommend deleting the visual links in "Visuals before/after changes are applied" sections in initial PR comment for future issues if visuals are not are not needed). Great job!

[rdhmdhl]

Great job following instructions! I've reviewed these changes to the pre-work-template---ux.md file and the labels match what was proposed in issue #4484

[roslynwythe]

Hi @arfgit great work on this PR so far. The branches are setup correctly and the code change appears to be correct. However I just learned that we may need to test the new template in a test repo on GitHub. I'm still trying to understand how to do that. I will try to work on it today 5/15 and tomorrow 5/16.

outdated

[roslynwythe]

Hi @arfgit I spoke with Bonnie and Justin about this, and we need to test the PR in a test repository. I will post the test procedure when it is ready. Thanks.

[arfgit]

Okay gotcha thanks for the update

[t-will-gillis]

Hi @arfgit - great job on your first good issue! You are using the correct branches, you linked the issue, your description is clear, and you followed the issue and made the code changes as requested.

You did what you were instructed to do- thanks!- but inadvertently the code we said to use has some typos. Instead would you please replace the code on Line 5 with the following-

labels: ['Feature: Onboarding/Contributing.md', 'prework', 'role: user research', 'size: 1pt', 'Complexity: Missing']

As @roslynwythe indicated, this will need to be tested and we will give you instructions for doing so. One minor observation- when you don't have 'before' and 'after' visuals you can delete the 'Visuals before ...' and 'Visuals after ...' and replace with 'No changes to the website' or similar.

Great job again, apologies for our typo, and thank you for your work

[arfgit]

No worries, let me know if things are good now!

[t-will-gillis]

Hey @arfgit - thanks for making the change, looks good! I am able to test it and it appears to work as intended.

For you to test it also: @roslynwythe posted instructions for testing here. Feel free to message us on Slack if you run into any issues. Thanks again!

PS when you make changes requested by a reviewer, you can select the circling arrows next to their name to re-request a review:

[roslynwythe]

Hi @arfgit I tested the PR and it checks out fine on the test repository, so I'm going to merge it. I apologize for the confusion about testing and I want to thank you for a great job on your "first good issue".