Update missing labels for Complexity and size in Communities of Practice information updates#4689
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Thursday and Sunday from 7am to 5pm |
93Belen
left a comment
There was a problem hiding this comment.
The PR is done from the correct branch.
You linked the issue, explained your changes and why you did them.
You explained how to review this issue, since the changes aren't visible on the website. Thanks for adding the link to review in your description!
The changes in the code are the ones the Issue ask for.
Good job!
|
Hey @imvan2 could you list your eta/availability? |
|
Hi, sorry! Review ETA: 6 PM 5/19/23 |
|
Review ETA: 5/19/23 |
imvan2
left a comment
There was a problem hiding this comment.
Hi @matthewmpan, great job on this PR! You've setup the branches correctly, described what you did, and included screenshots of the changes. I was able to verify that the labels have been added correctly to the issue template. Thanks for your work!
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @matthewmpan - Excellent job!
You have the correct branches, you're linked to the issue, your description is details what you did and why and includes relevant screenshots and a 'Link for Reviewers', and your code does exactly what it needs to.
|
@93Belen @imvan2 Thanks for reviewing! @t-will-gillis Thanks for reviewing and merging! |
Fixes #4486
What changes did you make and why did you make them ?
'Complexity: Missing'and'size: missing'in.github/ISSUE_TEMPLATE/communities-of-practice-information-updates.ymlScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.
Link for Reviewers
URL of the issue branch on the test Repository: https://github.com/matthewmpan/website/issues/new?assignees=&labels=role%3A+product%2CP-Feature%3A+Communities+of+Practice%2Ctime+sensitive%2CComplexity%3A+Missing%2Csize%3A+missing&projects=&template=communities-of-practice-information-updates.yml&title=Communities+of+Practice+information+updates%3A+%5BINSERT+NAME+OF+Community+of+Practice%5D