Skip to content

Update missing labels for Complexity and size in Communities of Practice information updates#4689

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
matthewmpan:update-template-label-CoP-4486
May 21, 2023
Merged

Update missing labels for Complexity and size in Communities of Practice information updates#4689
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
matthewmpan:update-template-label-CoP-4486

Conversation

@matthewmpan
Copy link
Member

Fixes #4486

What changes did you make and why did you make them ?

  • Added missing labels for 'Complexity: Missing' and 'size: missing' in .github/ISSUE_TEMPLATE/communities-of-practice-information-updates.yml
  • Change made to avoid the GitHub bot taking off the labels when devs add them to issues.
  • Missing labels are important to know for issue creators. They indicate that a label of a certain series is missing from the issue.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screen Shot 2023-05-17 at 11 38 46 PM
Visuals after changes are applied Screen Shot 2023-05-17 at 11 38 54 PM

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers
URL of the issue branch on the test Repository: https://github.com/matthewmpan/website/issues/new?assignees=&labels=role%3A+product%2CP-Feature%3A+Communities+of+Practice%2Ctime+sensitive%2CComplexity%3A+Missing%2Csize%3A+missing&projects=&template=communities-of-practice-information-updates.yml&title=Communities+of+Practice+information+updates%3A+%5BINSERT+NAME+OF+Community+of+Practice%5D

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b matthewmpan-update-template-label-CoP-4486 gh-pages
git pull https://github.com/matthewmpan/website.git update-template-label-CoP-4486

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels May 18, 2023
@matthewmpan matthewmpan changed the title Updated missing labels for Complexity and size Update missing labels for Complexity and size in Communities of Practice information updates May 18, 2023
@93Belen 93Belen self-requested a review May 18, 2023 11:08
@93Belen
Copy link
Member

93Belen commented May 18, 2023

Availability: Thursday and Sunday from 7am to 5pm
ETA: Thursday by 10am

Copy link
Member

@93Belen 93Belen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is done from the correct branch.
You linked the issue, explained your changes and why you did them.
You explained how to review this issue, since the changes aren't visible on the website. Thanks for adding the link to review in your description!
The changes in the code are the ones the Issue ask for.
Good job!

@matthewmpan matthewmpan requested a review from imvan2 May 18, 2023 19:39
@blulady
Copy link
Member

blulady commented May 18, 2023

Hey @imvan2 could you list your eta/availability?

@imvan2
Copy link
Member

imvan2 commented May 18, 2023

Hi, sorry!

Review ETA: 6 PM 5/19/23
Availability: M-F 3-6pm

@vanyanv vanyanv self-requested a review May 18, 2023 22:48
@vanyanv
Copy link
Member

vanyanv commented May 18, 2023

Review ETA: 5/19/23
Availability: M-F 10-5pm

Copy link
Member

@imvan2 imvan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matthewmpan, great job on this PR! You've setup the branches correctly, described what you did, and included screenshots of the changes. I was able to verify that the labels have been added correctly to the issue template. Thanks for your work!

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @matthewmpan - Excellent job!

You have the correct branches, you're linked to the issue, your description is details what you did and why and includes relevant screenshots and a 'Link for Reviewers', and your code does exactly what it needs to.

@t-will-gillis t-will-gillis merged commit c1e2018 into hackforla:gh-pages May 21, 2023
@matthewmpan
Copy link
Member Author

@93Belen @imvan2 Thanks for reviewing! @t-will-gillis Thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update labels: communities-of-practice-information-updates

6 participants