Update labels in the Mobile_responsiveness.yml file#4697
Update labels in the Mobile_responsiveness.yml file#4697t-will-gillis merged 5 commits intohackforla:gh-pagesfrom
Conversation
add labels for the blank-issue-form-with-no-dependancy issue template
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 05/19/23 10-12pm |
roslynwythe
left a comment
There was a problem hiding this comment.
Hi @rdhmdhl this PR looks great. You setup the branches correctly, the code change is correct and clean, and you described your work. Thank you for posting the link so reviewers can view the updated Mobile Responsiveness issue template in your fork on Github. I confirmed that the issue template includes the correct labels. I know the testing process for this issue was unusually complex and we really appreciate your pateience and effort to complete the job.
jenny-alexander
left a comment
There was a problem hiding this comment.
@rdhmdhl - this looks really good!
I see you put the linked issue in the PR.
The 3 additional labels appear in the issue template on the test repository (I checked via the link you provided in the PR).
The Mobile_responsiveness.yml file contains the requested changes to add 3 new labels.
Thank you!
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @rdhmdhl - Great job! Your branches are correct, you're linking the issue, your description says what you did and why, you added the link to the issue creation on your repo and the visuals, and your code is clean and concise. Thanks for working on this
Fixes #4483
What changes did you make and why did you make them ?
Link for Reviewers
URL of the issue template on the test repository: https://github.com/rdhmdhl/website/issues/new?assignees=&labels=role%3A+design%2CFeature+Missing%2CComplexity%3A+Missing%2Csize%3A+missing&projects=&template=Mobile_responsiveness.yml&title=Mobile+Responsiveness+on+%5Bname+of+the+page%5D+%3A+%5Bquick+recap+of+the+bug+here%5D
Visuals before changes are applied
Visuals after changes are applied