Skip to content

Update labels in the Mobile_responsiveness.yml file#4697

Merged
t-will-gillis merged 5 commits intohackforla:gh-pagesfrom
rdhmdhl:update-labels-4483
May 21, 2023
Merged

Update labels in the Mobile_responsiveness.yml file#4697
t-will-gillis merged 5 commits intohackforla:gh-pagesfrom
rdhmdhl:update-labels-4483

Conversation

@rdhmdhl
Copy link
Contributor

@rdhmdhl rdhmdhl commented May 19, 2023

Fixes #4483

What changes did you make and why did you make them ?

  • Update labels in the Mobile_responsiveness.yml file
  • Made this change to add the labels from the Missing series so that we can avoid the GitHub bot taking off the labels when devs add them to issues.

Link for Reviewers
URL of the issue template on the test repository: https://github.com/rdhmdhl/website/issues/new?assignees=&labels=role%3A+design%2CFeature+Missing%2CComplexity%3A+Missing%2Csize%3A+missing&projects=&template=Mobile_responsiveness.yml&title=Mobile+Responsiveness+on+%5Bname+of+the+page%5D+%3A+%5Bquick+recap+of+the+bug+here%5D

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b rdhmdhl-update-labels-4483 gh-pages
git pull https://github.com/rdhmdhl/website.git update-labels-4483

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.5pt Can be done in 3 hours or less labels May 19, 2023
@jenny-alexander
Copy link
Member

Review ETA: 05/19/23 10-12pm
Availability: 05/19/23 10-2pm

@roslynwythe roslynwythe self-requested a review May 19, 2023 08:28
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rdhmdhl this PR looks great. You setup the branches correctly, the code change is correct and clean, and you described your work. Thank you for posting the link so reviewers can view the updated Mobile Responsiveness issue template in your fork on Github. I confirmed that the issue template includes the correct labels. I know the testing process for this issue was unusually complex and we really appreciate your pateience and effort to complete the job.

Copy link
Member

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdhmdhl - this looks really good!
I see you put the linked issue in the PR.
The 3 additional labels appear in the issue template on the test repository (I checked via the link you provided in the PR).
The Mobile_responsiveness.yml file contains the requested changes to add 3 new labels.

Thank you!

@t-will-gillis t-will-gillis self-requested a review May 21, 2023 15:35
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rdhmdhl - Great job! Your branches are correct, you're linking the issue, your description says what you did and why, you added the link to the issue creation on your repo and the visuals, and your code is clean and concise. Thanks for working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update labels: Issue Template: Mobile_responsiveness

4 participants